From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ryan Hsu <ryanhsu@qti.qualcomm.com>,
Govind Singh <govinds@qti.qualcomm.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>,
Ben Greear <greearb@candelatech.com>,
"Brian Norris" <briannorris@chromium.org>,
Colin Ian King <colin.king@canonical.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: move pci suspend/resume functions
Date: Thu, 2 Nov 2017 15:23:42 +0000 [thread overview]
Message-ID: <87mv44ln5v.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <20171102110903.2886660-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 2 Nov 2017 12:08:53 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> The combination of two patches has led to a build failure:
>
> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend=
':
> drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration=
of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-=
Werror=3Dimplicit-function-declaration]
> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume'=
:
> drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration=
of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-We=
rror=3Dimplicit-function-declaration]
>
> This moves the functions outside of the now incorrect #ifdef.
>
> Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is support=
ed but disabled")
> Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Brian has already fixed this, please check that:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=3Da=
th-next&id=3D20665a9076d48e9abd9a2db13d307f58f7ef6647
But apparently I forgot to merge ath-next to wireless-drivers-next, will
do that soon.
--=20
Kalle Valo=
next prev parent reply other threads:[~2017-11-02 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:08 [PATCH] ath10k: move pci suspend/resume functions Arnd Bergmann
2017-11-02 15:23 ` Kalle Valo [this message]
2017-11-02 15:40 ` Arnd Bergmann
2017-11-02 17:10 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv44ln5v.fsf@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=arnagara@qti.qualcomm.com \
--cc=arnd@arndb.de \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=colin.king@canonical.com \
--cc=govinds@qti.qualcomm.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryanhsu@qti.qualcomm.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).