Re: [PATCH] rsi: add driver and firmware version info

[Kalle Valo <kvalo@codeaurora.org>]

Amitkumar Karwar <amitkarwar@gmail.com> writes:

> From: Pavani Muthyala <pavani.muthyala@redpinesignals.com>
>
> We will dump information about driver and firmware versions,
> firmware file name and operating mode during initialization.
>
> Signed-off-by: Pavani Muthyala <pavani.muthyala@redpinesignals.com>
> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>

[...]

> +void rsi_print_version(struct rsi_common *common)
> +{
> +	memcpy(common->driver_ver, DRV_VER, ARRAY_SIZE(DRV_VER));
> +	common->driver_ver[ARRAY_SIZE(DRV_VER)] = '\0';
> +
> +	rsi_dbg(ERR_ZONE, "================================================\n");
> +	rsi_dbg(ERR_ZONE, "================ RSI Version Info ==============\n");
> +	rsi_dbg(ERR_ZONE, "================================================\n");
> +	rsi_dbg(ERR_ZONE, "FW Version\t: %d.%d.%d\n",
> +		common->lmac_ver.major, common->lmac_ver.minor,
> +		common->lmac_ver.release_num);
> +	rsi_dbg(ERR_ZONE, "Driver Version\t: %s", common->driver_ver);
> +	rsi_dbg(ERR_ZONE, "Operating mode\t: %d [%s]",
> +		common->oper_mode, opmode_str(common->oper_mode));
> +	rsi_dbg(ERR_ZONE, "Firmware file\t: %s", common->priv->fw_file_name);
> +	rsi_dbg(ERR_ZONE, "================================================\n");
> +}
> +

[...]

> +#define DRV_VER				"RS911X.NB0.NL.GNU.LNX.1.0"

The concept of a driver version does not really work with upstream
drivers. The history has shown multiple times that the driver version
won't be updated for years and thus it won't have any meaning. So better
remove driver_ver from the driver entirely.

-- 
Kalle Valo