* [PATCH] mwifiex: fixes the trivial print @ 2017-06-09 11:40 Caesar Wang 2017-06-13 6:28 ` Kalle Valo 0 siblings, 1 reply; 9+ messages in thread From: Caesar Wang @ 2017-06-09 11:40 UTC (permalink / raw) To: amitkarwar, huxm Cc: nishants, gbhat, kvalo, linux-wireless, netdev, linux-kernel, briannorris, jeffy.chen, Caesar Wang We have always met the unused log be printed as following. ... [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: cannot find cfp by band 2 & channel=13 freq=0 [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: cannot find cfp by band 2 & channel=13 freq=0 Maybe that's related to wifi regdom, since wifi default area was US and didn't support 12~14 channels. As Frequencies: * 2412 MHz [1] (30.0 dBm) * 2417 MHz [2] (30.0 dBm) * 2422 MHz [3] (30.0 dBm) * 2427 MHz [4] (30.0 dBm) * 2432 MHz [5] (30.0 dBm) * 2437 MHz [6] (30.0 dBm) * 2442 MHz [7] (30.0 dBm) * 2447 MHz [8] (30.0 dBm) * 2452 MHz [9] (30.0 dBm) * 2457 MHz [10] (30.0 dBm) * 2462 MHz [11] (30.0 dBm) * 2467 MHz [12] (disabled) * 2472 MHz [13] (disabled) * 2484 MHz [14] (disabled) Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c index 1ff2205..6e29943 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfp.c +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq) } } if (i == sband->n_channels) { - mwifiex_dbg(priv->adapter, ERROR, + mwifiex_dbg(priv->adapter, WARN, "%s: cannot find cfp by band %d\t" "& channel=%d freq=%d\n", __func__, band, channel, freq); -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] mwifiex: fixes the trivial print 2017-06-09 11:40 [PATCH] mwifiex: fixes the trivial print Caesar Wang @ 2017-06-13 6:28 ` Kalle Valo 2017-06-13 6:54 ` Caesar Wang 0 siblings, 1 reply; 9+ messages in thread From: Kalle Valo @ 2017-06-13 6:28 UTC (permalink / raw) To: Caesar Wang Cc: amitkarwar, huxm, nishants, gbhat, linux-wireless, netdev, linux-kernel, briannorris, jeffy.chen Caesar Wang <wxt@rock-chips.com> writes: > We have always met the unused log be printed as following. > > ... > [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: > cannot find cfp by band 2 & channel=13 freq=0 > [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: > cannot find cfp by band 2 & channel=13 freq=0 > > Maybe that's related to wifi regdom, since wifi default area > was US and didn't support 12~14 channels. > > As Frequencies: > * 2412 MHz [1] (30.0 dBm) > * 2417 MHz [2] (30.0 dBm) > * 2422 MHz [3] (30.0 dBm) > * 2427 MHz [4] (30.0 dBm) > * 2432 MHz [5] (30.0 dBm) > * 2437 MHz [6] (30.0 dBm) > * 2442 MHz [7] (30.0 dBm) > * 2447 MHz [8] (30.0 dBm) > * 2452 MHz [9] (30.0 dBm) > * 2457 MHz [10] (30.0 dBm) > * 2462 MHz [11] (30.0 dBm) > * 2467 MHz [12] (disabled) > * 2472 MHz [13] (disabled) > * 2484 MHz [14] (disabled) > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > --- > > drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c > index 1ff2205..6e29943 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfp.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c > @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq) > } > } > if (i == sband->n_channels) { > - mwifiex_dbg(priv->adapter, ERROR, > + mwifiex_dbg(priv->adapter, WARN, > "%s: cannot find cfp by band %d\t" > "& channel=%d freq=%d\n", > __func__, band, channel, freq); I don't see how this fixes anything, care to explain? And the title is quite vague. And I would rather fix the root cause, mwifiex folks please comment. -- Kalle Valo ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mwifiex: fixes the trivial print 2017-06-13 6:28 ` Kalle Valo @ 2017-06-13 6:54 ` Caesar Wang 2017-06-13 7:04 ` Kalle Valo 0 siblings, 1 reply; 9+ messages in thread From: Caesar Wang @ 2017-06-13 6:54 UTC (permalink / raw) To: Kalle Valo Cc: amitkarwar, huxm, nishants, gbhat, linux-wireless, netdev, linux-kernel, briannorris, jeffy.chen Kalle, 在 2017年06月13日 14:28, Kalle Valo 写道: > Caesar Wang <wxt@rock-chips.com> writes: > >> We have always met the unused log be printed as following. >> >> ... >> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >> cannot find cfp by band 2 & channel=13 freq=0 >> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >> cannot find cfp by band 2 & channel=13 freq=0 >> >> Maybe that's related to wifi regdom, since wifi default area >> was US and didn't support 12~14 channels. >> >> As Frequencies: >> * 2412 MHz [1] (30.0 dBm) >> * 2417 MHz [2] (30.0 dBm) >> * 2422 MHz [3] (30.0 dBm) >> * 2427 MHz [4] (30.0 dBm) >> * 2432 MHz [5] (30.0 dBm) >> * 2437 MHz [6] (30.0 dBm) >> * 2442 MHz [7] (30.0 dBm) >> * 2447 MHz [8] (30.0 dBm) >> * 2452 MHz [9] (30.0 dBm) >> * 2457 MHz [10] (30.0 dBm) >> * 2462 MHz [11] (30.0 dBm) >> * 2467 MHz [12] (disabled) >> * 2472 MHz [13] (disabled) >> * 2484 MHz [14] (disabled) >> >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >> --- >> >> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c >> index 1ff2205..6e29943 100644 >> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c >> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c >> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq) >> } >> } >> if (i == sband->n_channels) { >> - mwifiex_dbg(priv->adapter, ERROR, >> + mwifiex_dbg(priv->adapter, WARN, >> "%s: cannot find cfp by band %d\t" >> "& channel=%d freq=%d\n", >> __func__, band, channel, freq); > I don't see how this fixes anything, care to explain? And the title is > quite vague. Sorry for the description maybe unclear. I'm assuming the print log is expected for marvel wifi driver. Do we should use 'WARN' to instead of the 'ERROR' here. > > And I would rather fix the root cause, mwifiex folks please comment. Indeed, that's my expected. -Caesar > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mwifiex: fixes the trivial print 2017-06-13 6:54 ` Caesar Wang @ 2017-06-13 7:04 ` Kalle Valo 2017-06-13 7:42 ` Caesar Wang 0 siblings, 1 reply; 9+ messages in thread From: Kalle Valo @ 2017-06-13 7:04 UTC (permalink / raw) To: Caesar Wang Cc: amitkarwar, huxm, nishants, gbhat, linux-wireless, netdev, linux-kernel, briannorris, jeffy.chen Caesar Wang <wxt@rock-chips.com> writes: > Kalle, > > =E5=9C=A8 2017=E5=B9=B406=E6=9C=8813=E6=97=A5 14:28, Kalle Valo =E5=86=99= =E9=81=93: >> Caesar Wang <wxt@rock-chips.com> writes: >> >>> We have always met the unused log be printed as following. >>> >>> ... >>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >>> cannot find cfp by band 2 & channel=3D13 freq=3D0 >>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >>> cannot find cfp by band 2 & channel=3D13 freq=3D0 >>> >>> Maybe that's related to wifi regdom, since wifi default area >>> was US and didn't support 12~14 channels. >>> >>> As Frequencies: >>> * 2412 MHz [1] (30.0 dBm) >>> * 2417 MHz [2] (30.0 dBm) >>> * 2422 MHz [3] (30.0 dBm) >>> * 2427 MHz [4] (30.0 dBm) >>> * 2432 MHz [5] (30.0 dBm) >>> * 2437 MHz [6] (30.0 dBm) >>> * 2442 MHz [7] (30.0 dBm) >>> * 2447 MHz [8] (30.0 dBm) >>> * 2452 MHz [9] (30.0 dBm) >>> * 2457 MHz [10] (30.0 dBm) >>> * 2462 MHz [11] (30.0 dBm) >>> * 2467 MHz [12] (disabled) >>> * 2472 MHz [13] (disabled) >>> * 2484 MHz [14] (disabled) >>> >>> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >>> --- >>> >>> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/w= ireless/marvell/mwifiex/cfp.c >>> index 1ff2205..6e29943 100644 >>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c >>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c >>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 ba= nd, u16 channel, u32 freq) >>> } >>> } >>> if (i =3D=3D sband->n_channels) { >>> - mwifiex_dbg(priv->adapter, ERROR, >>> + mwifiex_dbg(priv->adapter, WARN, >>> "%s: cannot find cfp by band %d\t" >>> "& channel=3D%d freq=3D%d\n", >>> __func__, band, channel, freq); >> I don't see how this fixes anything, care to explain? And the title is >> quite vague. > > Sorry for the description maybe unclear. > I'm assuming the print log is expected for marvel wifi driver. Do we > should use 'WARN' to instead of the 'ERROR' here. But does that make any functional difference, isn't the warning still printed? --=20 Kalle Valo ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mwifiex: fixes the trivial print 2017-06-13 7:04 ` Kalle Valo @ 2017-06-13 7:42 ` Caesar Wang 2017-06-13 7:53 ` Kalle Valo 0 siblings, 1 reply; 9+ messages in thread From: Caesar Wang @ 2017-06-13 7:42 UTC (permalink / raw) To: Kalle Valo Cc: amitkarwar, huxm, nishants, gbhat, linux-wireless, netdev, linux-kernel, briannorris, jeffy.chen 在 2017年06月13日 15:04, Kalle Valo 写道: > Caesar Wang <wxt@rock-chips.com> writes: > >> Kalle, >> >> 在 2017年06月13日 14:28, Kalle Valo 写道: >>> Caesar Wang <wxt@rock-chips.com> writes: >>> >>>> We have always met the unused log be printed as following. >>>> >>>> ... >>>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >>>> cannot find cfp by band 2 & channel=13 freq=0 >>>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >>>> cannot find cfp by band 2 & channel=13 freq=0 >>>> >>>> Maybe that's related to wifi regdom, since wifi default area >>>> was US and didn't support 12~14 channels. >>>> >>>> As Frequencies: >>>> * 2412 MHz [1] (30.0 dBm) >>>> * 2417 MHz [2] (30.0 dBm) >>>> * 2422 MHz [3] (30.0 dBm) >>>> * 2427 MHz [4] (30.0 dBm) >>>> * 2432 MHz [5] (30.0 dBm) >>>> * 2437 MHz [6] (30.0 dBm) >>>> * 2442 MHz [7] (30.0 dBm) >>>> * 2447 MHz [8] (30.0 dBm) >>>> * 2452 MHz [9] (30.0 dBm) >>>> * 2457 MHz [10] (30.0 dBm) >>>> * 2462 MHz [11] (30.0 dBm) >>>> * 2467 MHz [12] (disabled) >>>> * 2472 MHz [13] (disabled) >>>> * 2484 MHz [14] (disabled) >>>> >>>> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >>>> --- >>>> >>>> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c >>>> index 1ff2205..6e29943 100644 >>>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c >>>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c >>>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq) >>>> } >>>> } >>>> if (i == sband->n_channels) { >>>> - mwifiex_dbg(priv->adapter, ERROR, >>>> + mwifiex_dbg(priv->adapter, WARN, >>>> "%s: cannot find cfp by band %d\t" >>>> "& channel=%d freq=%d\n", >>>> __func__, band, channel, freq); >>> I don't see how this fixes anything, care to explain? And the title is >>> quite vague. >> Sorry for the description maybe unclear. >> I'm assuming the print log is expected for marvel wifi driver. Do we >> should use 'WARN' to instead of the 'ERROR' here. > But does that make any functional difference, isn't the warning still > printed? > At least, that shouldn't be printed log by default. :) if I read the code is correct. That only the MSG/FATAL/ERROR will output by default. /** *enum mwifiex_debug_level - marvell wifi debug level */ enum MWIFIEX_DEBUG_LEVEL { MWIFIEX_DBG_MSG = 0x00000001, MWIFIEX_DBG_FATAL = 0x00000002, MWIFIEX_DBG_ERROR = 0x00000004, MWIFIEX_DBG_DATA = 0x00000008, MWIFIEX_DBG_CMD = 0x00000010, MWIFIEX_DBG_EVENT = 0x00000020, MWIFIEX_DBG_INTR = 0x00000040, MWIFIEX_DBG_IOCTL = 0x00000080, MWIFIEX_DBG_MPA_D = 0x00008000, MWIFIEX_DBG_DAT_D = 0x00010000, MWIFIEX_DBG_CMD_D = 0x00020000, MWIFIEX_DBG_EVT_D = 0x00040000, MWIFIEX_DBG_FW_D = 0x00080000, MWIFIEX_DBG_IF_D = 0x00100000, MWIFIEX_DBG_ENTRY = 0x10000000, MWIFIEX_DBG_WARN = 0x20000000, MWIFIEX_DBG_INFO = 0x40000000, MWIFIEX_DBG_DUMP = 0x80000000, MWIFIEX_DBG_ANY = 0xffffffff }; #define MWIFIEX_DEFAULT_DEBUG_MASK (MWIFIEX_DBG_MSG | \ MWIFIEX_DBG_FATAL | \ MWIFIEX_DBG_ERROR) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mwifiex: fixes the trivial print 2017-06-13 7:42 ` Caesar Wang @ 2017-06-13 7:53 ` Kalle Valo 2017-06-13 9:51 ` Xinming Hu 0 siblings, 1 reply; 9+ messages in thread From: Kalle Valo @ 2017-06-13 7:53 UTC (permalink / raw) To: Caesar Wang Cc: amitkarwar, huxm, nishants, gbhat, linux-wireless, netdev, linux-kernel, briannorris, jeffy.chen Caesar Wang <wxt@rock-chips.com> writes: > =E5=9C=A8 2017=E5=B9=B406=E6=9C=8813=E6=97=A5 15:04, Kalle Valo =E5=86=99= =E9=81=93: >> Caesar Wang <wxt@rock-chips.com> writes: >> >>> Kalle, >>> >>> =E5=9C=A8 2017=E5=B9=B406=E6=9C=8813=E6=97=A5 14:28, Kalle Valo =E5=86= =99=E9=81=93: >>>> Caesar Wang <wxt@rock-chips.com> writes: >>>> >>>>> We have always met the unused log be printed as following. >>>>> >>>>> ... >>>>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >>>>> cannot find cfp by band 2 & channel=3D13 freq=3D0 >>>>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: >>>>> cannot find cfp by band 2 & channel=3D13 freq=3D0 >>>>> >>>>> Maybe that's related to wifi regdom, since wifi default area >>>>> was US and didn't support 12~14 channels. >>>>> >>>>> As Frequencies: >>>>> * 2412 MHz [1] (30.0 dBm) >>>>> * 2417 MHz [2] (30.0 dBm) >>>>> * 2422 MHz [3] (30.0 dBm) >>>>> * 2427 MHz [4] (30.0 dBm) >>>>> * 2432 MHz [5] (30.0 dBm) >>>>> * 2437 MHz [6] (30.0 dBm) >>>>> * 2442 MHz [7] (30.0 dBm) >>>>> * 2447 MHz [8] (30.0 dBm) >>>>> * 2452 MHz [9] (30.0 dBm) >>>>> * 2457 MHz [10] (30.0 dBm) >>>>> * 2462 MHz [11] (30.0 dBm) >>>>> * 2467 MHz [12] (disabled) >>>>> * 2472 MHz [13] (disabled) >>>>> * 2484 MHz [14] (disabled) >>>>> >>>>> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >>>>> --- >>>>> >>>>> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net= /wireless/marvell/mwifiex/cfp.c >>>>> index 1ff2205..6e29943 100644 >>>>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c >>>>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c >>>>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 = band, u16 channel, u32 freq) >>>>> } >>>>> } >>>>> if (i =3D=3D sband->n_channels) { >>>>> - mwifiex_dbg(priv->adapter, ERROR, >>>>> + mwifiex_dbg(priv->adapter, WARN, >>>>> "%s: cannot find cfp by band %d\t" >>>>> "& channel=3D%d freq=3D%d\n", >>>>> __func__, band, channel, freq); >>>> I don't see how this fixes anything, care to explain? And the title is >>>> quite vague. >>> Sorry for the description maybe unclear. >>> I'm assuming the print log is expected for marvel wifi driver. Do we >>> should use 'WARN' to instead of the 'ERROR' here. >> But does that make any functional difference, isn't the warning still >> printed? >> > > At least, that shouldn't be printed log by default. :) > > if I read the code is correct. That only the MSG/FATAL/ERROR will > output by default. > > /** > *enum mwifiex_debug_level - marvell wifi debug level > */ > enum MWIFIEX_DEBUG_LEVEL { > MWIFIEX_DBG_MSG =3D 0x00000001, > MWIFIEX_DBG_FATAL =3D 0x00000002, > MWIFIEX_DBG_ERROR =3D 0x00000004, > MWIFIEX_DBG_DATA =3D 0x00000008, > MWIFIEX_DBG_CMD =3D 0x00000010, > MWIFIEX_DBG_EVENT =3D 0x00000020, > MWIFIEX_DBG_INTR =3D 0x00000040, > MWIFIEX_DBG_IOCTL =3D 0x00000080, > > MWIFIEX_DBG_MPA_D =3D 0x00008000, > MWIFIEX_DBG_DAT_D =3D 0x00010000, > MWIFIEX_DBG_CMD_D =3D 0x00020000, > MWIFIEX_DBG_EVT_D =3D 0x00040000, > MWIFIEX_DBG_FW_D =3D 0x00080000, > MWIFIEX_DBG_IF_D =3D 0x00100000, > > MWIFIEX_DBG_ENTRY =3D 0x10000000, > MWIFIEX_DBG_WARN =3D 0x20000000, > MWIFIEX_DBG_INFO =3D 0x40000000, > MWIFIEX_DBG_DUMP =3D 0x80000000, > > MWIFIEX_DBG_ANY =3D 0xffffffff > }; > > #define MWIFIEX_DEFAULT_DEBUG_MASK (MWIFIEX_DBG_MSG | \ > MWIFIEX_DBG_FATAL | \ > MWIFIEX_DBG_ERROR) Heh, makes more sense now :) But you still should improve the title and explain in the commit log that WARN level is not printed by default. But before you submit v2 let's wait what Marvell says about this. --=20 Kalle Valo ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Re: [PATCH] mwifiex: fixes the trivial print 2017-06-13 7:53 ` Kalle Valo @ 2017-06-13 9:51 ` Xinming Hu [not found] ` <cf947dd3-e3a9-e940-fa15-393c9d952f32@rock-chips.com> 0 siblings, 1 reply; 9+ messages in thread From: Xinming Hu @ 2017-06-13 9:51 UTC (permalink / raw) To: Kalle Valo, Caesar Wang, Zhiyuan Yang, Cathy Luo Cc: amitkarwar@gmail.com, Nishant Sarmukadam, Ganapathi Bhat, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, jeffy.chen@rock-chips.com SGkgQ2Flc2FyLA0KDQpUaGUgb3JpZ2luYWwgbG9nIGluIGdvb2dsZSBpc3N1ZSB0cmFja2VyIHNo b3cgdGhlcmUgZXhpc3QgQVAgaW4gY2hhbm5lbCAxMyBhZnRlciBwZXJpb2RpY2FsbHkgc2Nhbi4g DQpQZXIgbXkgdW5kZXJzdGFuZCwgaWYgcmVnIGRvbWFpbiBpcyBzZXQgdG8gVVMsICBjaGFubmVs IDEyLzEzLzE0IHdpbGwgbm90IGdldCBjaGFuY2UgdG8gc2Nhbi4gKHRlc3QgdXNpbmcgaXcvd3Bh X3N1cHBsaWNhbnQpLg0KSSBhbSBjdXJpb3VzIGFib3V0IHdoZXRoZXIgdGhlcmUgYXJlIGFueSBk aWZmIGZyb20gdXBwZXIgbGF5ZXIuDQoNCkFzIGEgdGVzdCwgeW91IGNhbiBwcmludCB0aGUgc2Nh biBjaGFubmVsIGxpc3QsIGFzIGJlbG93Og0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2ly ZWxlc3MvbWFydmVsbC9td2lmaWV4L2NmZzgwMjExLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9t YXJ2ZWxsL213aWZpZXgvY2ZnODAyMTEuYw0KaW5kZXggYTc1OTNhYS4uYTI4OTgxOCAxMDA2NDQN Ci0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmlleC9jZmc4MDIxMS5jDQor KysgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvY2ZnODAyMTEuYw0KQEAg LTI1NzIsNiArMjU3Miw3IEBAIHN0YXRpYyBpbnQgbXdpZmlleF9zZXRfaWJzc19wYXJhbXMoc3Ry dWN0IG13aWZpZXhfcHJpdmF0ZSAqcHJpdiwNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IE1XSUZJRVhfVVNFUl9TQ0FOX0NIQU5fTUFYKTsgaSsrKSB7DQogICAgICAgICAgICAgICAgY2hh biA9IHJlcXVlc3QtPmNoYW5uZWxzW2ldOw0KICAgICAgICAgICAgICAgIHVzZXJfc2Nhbl9jZmct PmNoYW5fbGlzdFtpXS5jaGFuX251bWJlciA9IGNoYW4tPmh3X3ZhbHVlOw0KKyAgICAgICAgICAg ICAgIHByX2VycigiY2hhbi0+aHdfdmFsdWUgPSAlZCIsIGNoYW4tPmh3X3ZhbHVlKTsNCiAgICAg ICAgICAgICAgICB1c2VyX3NjYW5fY2ZnLT5jaGFuX2xpc3RbaV0ucmFkaW9fdHlwZSA9IGNoYW4t PmJhbmQ7DQogDQogICAgICAgICAgICAgICAgaWYgKChjaGFuLT5mbGFncyAmIElFRUU4MDIxMV9D SEFOX05PX0lSKSB8fCAhcmVxdWVzdC0+bl9zc2lkcykNCg0KUmVnYXJkcywNClNpbW9uDQoNCj4g LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogS2FsbGUgVmFsbyBbbWFpbHRvOmt2 YWxvQGNvZGVhdXJvcmEub3JnXQ0KPiBTZW50OiAyMDE35bm0NuaciDEz5pelIDE1OjUzDQo+IFRv OiBDYWVzYXIgV2FuZw0KPiBDYzogYW1pdGthcndhckBnbWFpbC5jb207IFhpbm1pbmcgSHU7IE5p c2hhbnQgU2FybXVrYWRhbTsgR2FuYXBhdGhpDQo+IEJoYXQ7IGxpbnV4LXdpcmVsZXNzQHZnZXIu a2VybmVsLm9yZzsgbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsNCj4gbGludXgta2VybmVsQHZnZXIu a2VybmVsLm9yZzsgYnJpYW5ub3JyaXNAY2hyb21pdW0ub3JnOw0KPiBqZWZmeS5jaGVuQHJvY2st Y2hpcHMuY29tDQo+IFN1YmplY3Q6IFtFWFRdIFJlOiBbUEFUQ0hdIG13aWZpZXg6IGZpeGVzIHRo ZSB0cml2aWFsIHByaW50DQo+IA0KPiBFeHRlcm5hbCBFbWFpbA0KPiANCj4gLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQ0KPiBDYWVzYXIgV2FuZyA8d3h0QHJvY2stY2hpcHMuY29tPiB3cml0ZXM6DQo+IA0KPiA+IOWc qCAyMDE35bm0MDbmnIgxM+aXpSAxNTowNCwgS2FsbGUgVmFsbyDlhpnpgZM6DQo+ID4+IENhZXNh ciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+IHdyaXRlczoNCj4gPj4NCj4gPj4+IEthbGxlLA0K PiA+Pj4NCj4gPj4+IOWcqCAyMDE35bm0MDbmnIgxM+aXpSAxNDoyOCwgS2FsbGUgVmFsbyDlhpnp gZM6DQo+ID4+Pj4gQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNoaXBzLmNvbT4gd3JpdGVzOg0KPiA+ Pj4+DQo+ID4+Pj4+IFdlIGhhdmUgYWx3YXlzIG1ldCB0aGUgdW51c2VkIGxvZyBiZSBwcmludGVk IGFzIGZvbGxvd2luZy4NCj4gPj4+Pj4NCj4gPj4+Pj4gLi4uDQo+ID4+Pj4+IFsyMzE5My41MjMx ODJdIG13aWZpZXhfcGNpZSAwMDAwOjAxOjAwLjA6IG13aWZpZXhfZ2V0X2NmcDoNCj4gPj4+Pj4g Y2Fubm90IGZpbmQgY2ZwIGJ5IGJhbmQgMiAgICAmIGNoYW5uZWw9MTMgZnJlcT0wDQo+ID4+Pj4+ IFsyMzM3OC42MzM2ODRdIG13aWZpZXhfcGNpZSAwMDAwOjAxOjAwLjA6IG13aWZpZXhfZ2V0X2Nm cDoNCj4gPj4+Pj4gY2Fubm90IGZpbmQgY2ZwIGJ5IGJhbmQgMiAgICAmIGNoYW5uZWw9MTMgZnJl cT0wDQo+ID4+Pj4+DQo+ID4+Pj4+IE1heWJlIHRoYXQncyByZWxhdGVkIHRvIHdpZmkgcmVnZG9t LCBzaW5jZSB3aWZpIGRlZmF1bHQgYXJlYSB3YXMNCj4gPj4+Pj4gVVMgYW5kIGRpZG4ndCBzdXBw b3J0IDEyfjE0IGNoYW5uZWxzLg0KPiA+Pj4+Pg0KPiA+Pj4+PiBBcyBGcmVxdWVuY2llczoNCj4g Pj4+Pj4gKiAyNDEyIE1IeiBbMV0gKDMwLjAgZEJtKQ0KPiA+Pj4+PiAqIDI0MTcgTUh6IFsyXSAo MzAuMCBkQm0pDQo+ID4+Pj4+ICogMjQyMiBNSHogWzNdICgzMC4wIGRCbSkNCj4gPj4+Pj4gKiAy NDI3IE1IeiBbNF0gKDMwLjAgZEJtKQ0KPiA+Pj4+PiAqIDI0MzIgTUh6IFs1XSAoMzAuMCBkQm0p DQo+ID4+Pj4+ICogMjQzNyBNSHogWzZdICgzMC4wIGRCbSkNCj4gPj4+Pj4gKiAyNDQyIE1IeiBb N10gKDMwLjAgZEJtKQ0KPiA+Pj4+PiAqIDI0NDcgTUh6IFs4XSAoMzAuMCBkQm0pDQo+ID4+Pj4+ ICogMjQ1MiBNSHogWzldICgzMC4wIGRCbSkNCj4gPj4+Pj4gKiAyNDU3IE1IeiBbMTBdICgzMC4w IGRCbSkNCj4gPj4+Pj4gKiAyNDYyIE1IeiBbMTFdICgzMC4wIGRCbSkNCj4gPj4+Pj4gKiAyNDY3 IE1IeiBbMTJdIChkaXNhYmxlZCkNCj4gPj4+Pj4gKiAyNDcyIE1IeiBbMTNdIChkaXNhYmxlZCkN Cj4gPj4+Pj4gKiAyNDg0IE1IeiBbMTRdIChkaXNhYmxlZCkNCj4gPj4+Pj4NCj4gPj4+Pj4gU2ln bmVkLW9mZi1ieTogQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNoaXBzLmNvbT4NCj4gPj4+Pj4gLS0t DQo+ID4+Pj4+DQo+ID4+Pj4+ICAgIGRyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmll eC9jZnAuYyB8IDIgKy0NCj4gPj4+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pDQo+ID4+Pj4+DQo+ID4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25l dC93aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvY2ZwLmMNCj4gPj4+Pj4gYi9kcml2ZXJzL25ldC93 aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvY2ZwLmMNCj4gPj4+Pj4gaW5kZXggMWZmMjIwNS4uNmUy OTk0MyAxMDA2NDQNCj4gPj4+Pj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvbWFydmVsbC9t d2lmaWV4L2NmcC5jDQo+ID4+Pj4+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwv bXdpZmlleC9jZnAuYw0KPiA+Pj4+PiBAQCAtMzUwLDcgKzM1MCw3IEBAIG13aWZpZXhfZ2V0X2Nm cChzdHJ1Y3QgbXdpZmlleF9wcml2YXRlICpwcml2LCB1OA0KPiBiYW5kLCB1MTYgY2hhbm5lbCwg dTMyIGZyZXEpDQo+ID4+Pj4+ICAgIAkJfQ0KPiA+Pj4+PiAgICAJfQ0KPiA+Pj4+PiAgICAJaWYg KGkgPT0gc2JhbmQtPm5fY2hhbm5lbHMpIHsNCj4gPj4+Pj4gLQkJbXdpZmlleF9kYmcocHJpdi0+ YWRhcHRlciwgRVJST1IsDQo+ID4+Pj4+ICsJCW13aWZpZXhfZGJnKHByaXYtPmFkYXB0ZXIsIFdB Uk4sDQo+ID4+Pj4+ICAgIAkJCSAgICAiJXM6IGNhbm5vdCBmaW5kIGNmcCBieSBiYW5kICVkXHQi DQo+ID4+Pj4+ICAgIAkJCSAgICAiJiBjaGFubmVsPSVkIGZyZXE9JWRcbiIsDQo+ID4+Pj4+ICAg IAkJCSAgICBfX2Z1bmNfXywgYmFuZCwgY2hhbm5lbCwgZnJlcSk7DQo+ID4+Pj4gSSBkb24ndCBz ZWUgaG93IHRoaXMgZml4ZXMgYW55dGhpbmcsIGNhcmUgdG8gZXhwbGFpbj8gQW5kIHRoZSB0aXRs ZQ0KPiA+Pj4+IGlzIHF1aXRlIHZhZ3VlLg0KPiA+Pj4gU29ycnkgZm9yIHRoZSBkZXNjcmlwdGlv biBtYXliZSB1bmNsZWFyLg0KPiA+Pj4gSSdtIGFzc3VtaW5nIHRoZSBwcmludCBsb2cgaXMgZXhw ZWN0ZWQgZm9yIG1hcnZlbCB3aWZpIGRyaXZlci4gRG8gd2UNCj4gPj4+IHNob3VsZCB1c2UgJ1dB Uk4nIHRvIGluc3RlYWQgb2YgdGhlICdFUlJPUicgaGVyZS4NCj4gPj4gQnV0IGRvZXMgdGhhdCBt YWtlIGFueSBmdW5jdGlvbmFsIGRpZmZlcmVuY2UsIGlzbid0IHRoZSB3YXJuaW5nIHN0aWxsDQo+ ID4+IHByaW50ZWQ/DQo+ID4+DQo+ID4NCj4gPiBBdCBsZWFzdCwgdGhhdCBzaG91bGRuJ3QgYmUg cHJpbnRlZCBsb2cgYnkgZGVmYXVsdC4gIDopDQo+ID4NCj4gPiBpZiBJIHJlYWQgdGhlIGNvZGUg aXMgY29ycmVjdC4gVGhhdCBvbmx5IHRoZSBNU0cvRkFUQUwvRVJST1Igd2lsbA0KPiA+IG91dHB1 dCBieSBkZWZhdWx0Lg0KPiA+DQo+ID4gLyoqDQo+ID4gICplbnVtIG13aWZpZXhfZGVidWdfbGV2 ZWwgIC0gIG1hcnZlbGwgd2lmaSBkZWJ1ZyBsZXZlbCAgKi8gZW51bQ0KPiA+IE1XSUZJRVhfREVC VUdfTEVWRUwgew0KPiA+ICAgICBNV0lGSUVYX0RCR19NU0cgICAgICAgID0gMHgwMDAwMDAwMSwN Cj4gPiAgICAgTVdJRklFWF9EQkdfRkFUQUwgICAgPSAweDAwMDAwMDAyLA0KPiA+ICAgICBNV0lG SUVYX0RCR19FUlJPUiAgICA9IDB4MDAwMDAwMDQsDQo+ID4gICAgIE1XSUZJRVhfREJHX0RBVEEg ICAgPSAweDAwMDAwMDA4LA0KPiA+ICAgICBNV0lGSUVYX0RCR19DTUQgICAgICAgID0gMHgwMDAw MDAxMCwNCj4gPiAgICAgTVdJRklFWF9EQkdfRVZFTlQgICAgPSAweDAwMDAwMDIwLA0KPiA+ICAg ICBNV0lGSUVYX0RCR19JTlRSICAgID0gMHgwMDAwMDA0MCwNCj4gPiAgICAgTVdJRklFWF9EQkdf SU9DVEwgICAgPSAweDAwMDAwMDgwLA0KPiA+DQo+ID4gICAgIE1XSUZJRVhfREJHX01QQV9EICAg ID0gMHgwMDAwODAwMCwNCj4gPiAgICAgTVdJRklFWF9EQkdfREFUX0QgICAgPSAweDAwMDEwMDAw LA0KPiA+ICAgICBNV0lGSUVYX0RCR19DTURfRCAgICA9IDB4MDAwMjAwMDAsDQo+ID4gICAgIE1X SUZJRVhfREJHX0VWVF9EICAgID0gMHgwMDA0MDAwMCwNCj4gPiAgICAgTVdJRklFWF9EQkdfRldf RCAgICA9IDB4MDAwODAwMDAsDQo+ID4gICAgIE1XSUZJRVhfREJHX0lGX0QgICAgPSAweDAwMTAw MDAwLA0KPiA+DQo+ID4gICAgIE1XSUZJRVhfREJHX0VOVFJZICAgID0gMHgxMDAwMDAwMCwNCj4g PiAgICAgTVdJRklFWF9EQkdfV0FSTiAgICA9IDB4MjAwMDAwMDAsDQo+ID4gICAgIE1XSUZJRVhf REJHX0lORk8gICAgPSAweDQwMDAwMDAwLA0KPiA+ICAgICBNV0lGSUVYX0RCR19EVU1QICAgID0g MHg4MDAwMDAwMCwNCj4gPg0KPiA+ICAgICBNV0lGSUVYX0RCR19BTlkgICAgICAgID0gMHhmZmZm ZmZmZg0KPiA+IH07DQo+ID4NCj4gPiAjZGVmaW5lIE1XSUZJRVhfREVGQVVMVF9ERUJVR19NQVNL ICAgIChNV0lGSUVYX0RCR19NU0cgfCBcDQo+ID4gICAgICAgICAgICAgICAgICAgICBNV0lGSUVY X0RCR19GQVRBTCB8IFwNCj4gPiAgICAgICAgICAgICAgICAgICAgIE1XSUZJRVhfREJHX0VSUk9S KQ0KPiANCj4gSGVoLCBtYWtlcyBtb3JlIHNlbnNlIG5vdyA6KSBCdXQgeW91IHN0aWxsIHNob3Vs ZCBpbXByb3ZlIHRoZSB0aXRsZSBhbmQNCj4gZXhwbGFpbiBpbiB0aGUgY29tbWl0IGxvZyB0aGF0 IFdBUk4gbGV2ZWwgaXMgbm90IHByaW50ZWQgYnkgZGVmYXVsdC4NCj4gDQo+IEJ1dCBiZWZvcmUg eW91IHN1Ym1pdCB2MiBsZXQncyB3YWl0IHdoYXQgTWFydmVsbCBzYXlzIGFib3V0IHRoaXMuDQo+ IA0KPiAtLQ0KPiBLYWxsZSBWYWxvDQo= ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <cf947dd3-e3a9-e940-fa15-393c9d952f32@rock-chips.com>]
* Re: Re: [PATCH] mwifiex: fixes the trivial print [not found] ` <cf947dd3-e3a9-e940-fa15-393c9d952f32@rock-chips.com> @ 2017-06-14 10:23 ` Xinming Hu 2017-06-14 11:11 ` Caesar Wang 0 siblings, 1 reply; 9+ messages in thread From: Xinming Hu @ 2017-06-14 10:23 UTC (permalink / raw) To: Caesar Wang, Kalle Valo, Zhiyuan Yang, Cathy Luo Cc: amitkarwar@gmail.com, Nishant Sarmukadam, Ganapathi Bhat, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, jeffy.chen@rock-chips.com, Ganapathi Bhat SGkgQ2Flc2FyLA0KDQpJdCBwcm92ZWQgdG8gYmUgYSBmZWF0dXJlIHRvIGdldCBiZXR0ZXIgc2Nh biByZXN1bHQgZnJvbSBvdmVybGFwcGluZyBjaGFubmVsLCBpbnRyb2R1Y2VkIGluDQoNCmNvbW1p dCAxYjQ5OWNiNzJmMjZiYmY0NGYyZmExNThjMmQxNDg3NzMwYWFlOTZhDQpBdXRob3I6IEFtaXRr dW1hciBLYXJ3YXIgPGFrYXJ3YXJAbWFydmVsbC5jb20+DQpEYXRlOiAgIFN1biBBcHIgMjQgMjM6 NDk6NTEgMjAxNiAtMDcwMA0KDQogICAgbXdpZmlleDogZGlzYWJsZSBjaGFubmVsIGZpbHRlcmlu ZyBmZWF0dXJlIGluIGZpcm13YXJlDQogICAgDQogICAgQXMgMi40R2h6IGNoYW5uZWxzIGFyZSBv dmVybGFwcGluZywgc29tZXRpbWVzIEFQIHJlc3BvbmRzIHRvDQogICAgcHJvYmUgcmVxdWVzdCBl dmVuIGlmIGl0J3Mgb3BlcmF0aW5nIG9uIG5laWdoYm91cmluZyBjaGFubmVsLg0KICAgIEN1cnJl bnRseSBmaXJtd2FyZSBkcm9wcyB0aG9zZSBzY2FuIGVudHJpZXMsIGFzIGN1cnJlbnQgY2hhbm5l bA0KICAgIGRvZXNuJ3QgbWF0Y2ggd2l0aCBBUHMgY2hhbm5lbC4NCiAgICANCiAgICBUaGlzIHBh dGNoIGVuYWJsZXMgTVdJRklFWF9ESVNBQkxFX0NIQU5fRklMVCBmbGFnIGluIHNjYW4NCiAgICBj b21tYW5kIHRvIGRpc2FibGUgdGhlIGZlYXR1cmUgc28gdGhhdCBiZXR0ZXIgc2NhbiByZXN1bHRz DQogICAgd2lsbCBiZSByZWNlaXZlZCBpbiAyLjRHaHogYmFuZC4NCg0KQXMgSSBjYW4gc2VlLCBl dmVuIHRoZXJlIGNvdWxkIGJlIEFQIGZyb20gb3ZlcmxhcHBpbmcgY2hhbm5lbCAobWlnaHQgYmUg MTIvMTMvMTQgaW4gdGhpcyBjYXNlKSwgIGl0IHdpbGwgYmUgZmlsdGVyZWQgZGVwZW5kIG9uIHJl ZyBkb21haW4gcnVsZXMNCiANCiAgICAgICBpZiAoY2gtPmZsYWdzICYgSUVFRTgwMjExX0NIQU5f RElTQUJMRUQpDQogICAgICAgICAgICBjb250aW51ZTsNCg0Kc28gaXQgc2hvdWxkIG5vdCBiZWVu IGFuIEVSUk9SLiBXQVJOIGxvb2tzIGZpbmUgdG8gbWUuDQp5b3UgY2FuIGFkZCBtZSBhY2tlZC1i eSBpbiB2Mi4NCg0KDQpSZWdhcmRzLA0KU2ltb24NCkZyb206IENhZXNhciBXYW5nIFttYWlsdG86 d3h0QHJvY2stY2hpcHMuY29tXSANClNlbnQ6IDIwMTflubQ25pyIMTPml6UgMTg6NTINClRvOiBY aW5taW5nIEh1OyBLYWxsZSBWYWxvOyBaaGl5dWFuIFlhbmc7IENhdGh5IEx1bw0KQ2M6IGFtaXRr YXJ3YXJAZ21haWwuY29tOyBOaXNoYW50IFNhcm11a2FkYW07IEdhbmFwYXRoaSBCaGF0OyBsaW51 eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmc7IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4 LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGJyaWFubm9ycmlzQGNocm9taXVtLm9yZzsgamVmZnku Y2hlbkByb2NrLWNoaXBzLmNvbTsgR2FuYXBhdGhpIEJoYXQNClN1YmplY3Q6IFtFWFRdIFJlOiBb UEFUQ0hdIG13aWZpZXg6IGZpeGVzIHRoZSB0cml2aWFsIHByaW50DQoNCkV4dGVybmFsIEVtYWls IA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KSGkgWGlubWluZywN CkFzIGlzc3VlIHRyYWNrZWQgb24gaHR0cHM6Ly9wYXJ0bmVyaXNzdWV0cmFja2VyLmNvcnAuZ29v Z2xlLmNvbS91LzIvaXNzdWVzLzYyMTIyODQzDQoNCg0K5ZyoIDIwMTflubQwNuaciDEz5pelIDE3 OjUxLCBYaW5taW5nIEh1IOWGmemBkzoNCkhpIENhZXNhciwNCg0KVGhlIG9yaWdpbmFsIGxvZyBp biBnb29nbGUgaXNzdWUgdHJhY2tlciBzaG93IHRoZXJlIGV4aXN0IEFQIGluIGNoYW5uZWwgMTMg YWZ0ZXIgcGVyaW9kaWNhbGx5IHNjYW4uIA0KUGVyIG15IHVuZGVyc3RhbmQsIGlmIHJlZyBkb21h aW4gaXMgc2V0IHRvIFVTLCAgY2hhbm5lbCAxMi8xMy8xNCB3aWxsIG5vdCBnZXQgY2hhbmNlIHRv IHNjYW4uICh0ZXN0IHVzaW5nIGl3L3dwYV9zdXBwbGljYW50KS4NCkkgYW0gY3VyaW91cyBhYm91 dCB3aGV0aGVyIHRoZXJlIGFyZSBhbnkgZGlmZiBmcm9tIHVwcGVyIGxheWVyLg0KDQpBcyBhIHRl c3QsIHlvdSBjYW4gcHJpbnQgdGhlIHNjYW4gY2hhbm5lbCBsaXN0LCBhcyBiZWxvdzoNCg0KZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmlleC9jZmc4MDIxMS5j IGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvbWFydmVsbC9td2lmaWV4L2NmZzgwMjExLmMNCmluZGV4 IGE3NTkzYWEuLmEyODk4MTggMTAwNjQ0DQotLS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9tYXJ2 ZWxsL213aWZpZXgvY2ZnODAyMTEuYw0KKysrIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvbWFydmVs bC9td2lmaWV4L2NmZzgwMjExLmMNCkBAIC0yNTcyLDYgKzI1NzIsNyBAQCBzdGF0aWMgaW50IG13 aWZpZXhfc2V0X2lic3NfcGFyYW1zKHN0cnVjdCBtd2lmaWV4X3ByaXZhdGUgKnByaXYsDQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBNV0lGSUVYX1VTRVJfU0NBTl9DSEFOX01BWCk7IGkr Kykgew0KICAgICAgICAgICAgICAgIGNoYW4gPSByZXF1ZXN0LT5jaGFubmVsc1tpXTsNCiAgICAg ICAgICAgICAgICB1c2VyX3NjYW5fY2ZnLT5jaGFuX2xpc3RbaV0uY2hhbl9udW1iZXIgPSBjaGFu LT5od192YWx1ZTsNCisgICAgICAgICAgICAgICBwcl9lcnIoImNoYW4tPmh3X3ZhbHVlID0gJWQi LCBjaGFuLT5od192YWx1ZSk7DQogICAgICAgICAgICAgICAgdXNlcl9zY2FuX2NmZy0+Y2hhbl9s aXN0W2ldLnJhZGlvX3R5cGUgPSBjaGFuLT5iYW5kOw0KIA0KICAgICAgICAgICAgICAgIGlmICgo Y2hhbi0+ZmxhZ3MgJiBJRUVFODAyMTFfQ0hBTl9OT19JUikgfHwgIXJlcXVlc3QtPm5fc3NpZHMp DQoNClRoZSBiZWxvdyBhcyB0aGUgcmVxdWlyZWQgbG9nOg0KbG9jYWxob3N0IC8gIyBbwqDCoCA0 Ni43NjA5OTddIG13aWZpZXg6IGNoYW4tPmh3X3ZhbHVlID0gMQ0KW8KgwqAgNDYuNzY0ODc4XSBt d2lmaWV4OiBjaGFuLT5od192YWx1ZSA9IDINClvCoMKgIDQ2Ljc2ODc2NV0gbXdpZmlleDogY2hh bi0+aHdfdmFsdWUgPSAzDQpbwqDCoCA0Ni43NzI2MjVdIG13aWZpZXg6IGNoYW4tPmh3X3ZhbHVl ID0gNA0KW8KgwqAgNDYuNzc2NjA4XSBtd2lmaWV4OiBjaGFuLT5od192YWx1ZSA9IDUNClvCoMKg IDQ2Ljc4MDQ4NV0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSA2DQpbwqDCoCA0Ni43ODQzODRd IG13aWZpZXg6IGNoYW4tPmh3X3ZhbHVlID0gNw0KW8KgwqAgNDYuNzg4MjUyXSBtd2lmaWV4OiBj aGFuLT5od192YWx1ZSA9IDgNClvCoMKgIDQ2Ljc5MjE4NV0gbXdpZmlleDogY2hhbi0+aHdfdmFs dWUgPSA5DQpbwqDCoCA0Ni43OTYwMzZdIG13aWZpZXg6IGNoYW4tPmh3X3ZhbHVlID0gMTANClvC oMKgIDQ2Ljc5OTk3OF0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxMQ0KW8KgwqAgNDYuODAz OTA4XSBtd2lmaWV4OiBjaGFuLT5od192YWx1ZSA9IDM4DQpbwqDCoCA0Ni44MDc4NDddIG13aWZp ZXg6IGNoYW4tPmh3X3ZhbHVlID0gNDINClvCoMKgIDQ2LjgxMTc4Nl0gbXdpZmlleDogY2hhbi0+ aHdfdmFsdWUgPSA0Ng0KW8KgwqAgNDYuODE1NzIyXSBtd2lmaWV4OiBjaGFuLT5od192YWx1ZSA9 IDM2DQpbwqDCoCA0Ni44MTk2NDZdIG13aWZpZXg6IGNoYW4tPmh3X3ZhbHVlID0gNDANClvCoMKg IDQ2LjgyMzU3N10gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSA0NA0KW8KgwqAgNDYuODI3NTAz XSBtd2lmaWV4OiBjaGFuLT5od192YWx1ZSA9IDQ4DQpbwqDCoCA0Ni44MzE0NDBdIG13aWZpZXg6 IGNoYW4tPmh3X3ZhbHVlID0gNTINClvCoMKgIDQ2LjgzNTM2M10gbXdpZmlleDogY2hhbi0+aHdf dmFsdWUgPSA1Ng0KW8KgwqAgNDYuODM5Mjg3XSBtd2lmaWV4OiBjaGFuLT5od192YWx1ZSA9IDYw DQpbwqDCoCA0Ni44NDMyMDVdIG13aWZpZXg6IGNoYW4tPmh3X3ZhbHVlID0gNjQNClvCoMKgIDQ2 Ljg0NzEyOV0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxMDANClvCoMKgIDQ2Ljg1MTEzNF0g bXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxMDQNClvCoMKgIDQ2Ljg1NTE1MF0gbXdpZmlleDog Y2hhbi0+aHdfdmFsdWUgPSAxMDgNClvCoMKgIDQ2Ljg1OTE1NV0gbXdpZmlleDogY2hhbi0+aHdf dmFsdWUgPSAxMTINClvCoMKgIDQ2Ljg2MzE2OF0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAx MTYNClvCoMKgIDQ2Ljg2NzE3NV0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxMjANClvCoMKg IDQ2Ljg3MTE4Nl0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxMjQNClvCoMKgIDQ2Ljg3NTE5 Nl0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxMjgNClvCoMKgIDQ2Ljg3OTIwOF0gbXdpZmll eDogY2hhbi0+aHdfdmFsdWUgPSAxMzINClvCoMKgIDQ2Ljg4MzIxNF0gbXdpZmlleDogY2hhbi0+ aHdfdmFsdWUgPSAxMzYNClvCoMKgIDQ2Ljg4NzIyNF0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUg PSAxNDANClvCoMKgIDQ2Ljg5MTIzMF0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxNDkNClvC oMKgIDQ2Ljg5NTI0MV0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxNTMNClvCoMKgIDQ2Ljg5 OTI0Nl0gbXdpZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxNTcNClvCoMKgIDQ2LjkwMzI1Nl0gbXdp ZmlleDogY2hhbi0+aHdfdmFsdWUgPSAxNjENClvCoMKgIDQ2LjkwNzI2Ml0gbXdpZmlleDogY2hh bi0+aHdfdmFsdWUgPSAxNjUNClvCoMKgIDQ3LjM5NDE3Nl0gbXdpZmlleF9wY2llIDAwMDA6MDE6 MDAuMDogbXdpZmlleF9nZXRfY2ZwOiBjYW5ub3QgZmluZCBjZnAgYnkgYmFuZCAywqDCoMKgICYg Y2hhbm5lbD0xMiBmcmVxPTANCg0KLUNhZXNhcg0KDQoNClJlZ2FyZHMsDQpTaW1vbg0KDQotLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogS2FsbGUgVmFsbyBbbWFpbHRvOmt2YWxvQGNv ZGVhdXJvcmEub3JnXQ0KU2VudDogMjAxN+W5tDbmnIgxM+aXpSAxNTo1Mw0KVG86IENhZXNhciBX YW5nDQpDYzogYW1pdGthcndhckBnbWFpbC5jb207IFhpbm1pbmcgSHU7IE5pc2hhbnQgU2FybXVr YWRhbTsgR2FuYXBhdGhpDQpCaGF0OyBsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmc7IG5l dGRldkB2Z2VyLmtlcm5lbC5vcmc7DQpsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBicmlh bm5vcnJpc0BjaHJvbWl1bS5vcmc7DQpqZWZmeS5jaGVuQHJvY2stY2hpcHMuY29tDQpTdWJqZWN0 OiBbRVhUXSBSZTogW1BBVENIXSBtd2lmaWV4OiBmaXhlcyB0aGUgdHJpdmlhbCBwcmludA0KDQpF eHRlcm5hbCBFbWFpbA0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpDYWVzYXIgV2FuZyA8d3h0QHJvY2stY2hp cHMuY29tPiB3cml0ZXM6DQoNCuWcqCAyMDE35bm0MDbmnIgxM+aXpSAxNTowNCwgS2FsbGUgVmFs byDlhpnpgZM6DQpDYWVzYXIgV2FuZyA8d3h0QHJvY2stY2hpcHMuY29tPiB3cml0ZXM6DQoNCkth bGxlLA0KDQrlnKggMjAxN+W5tDA25pyIMTPml6UgMTQ6MjgsIEthbGxlIFZhbG8g5YaZ6YGTOg0K Q2Flc2FyIFdhbmcgPHd4dEByb2NrLWNoaXBzLmNvbT4gd3JpdGVzOg0KDQpXZSBoYXZlIGFsd2F5 cyBtZXQgdGhlIHVudXNlZCBsb2cgYmUgcHJpbnRlZCBhcyBmb2xsb3dpbmcuDQoNCi4uLg0KWzIz MTkzLjUyMzE4Ml0gbXdpZmlleF9wY2llIDAwMDA6MDE6MDAuMDogbXdpZmlleF9nZXRfY2ZwOg0K Y2Fubm90IGZpbmQgY2ZwIGJ5IGJhbmQgMiAgICAmIGNoYW5uZWw9MTMgZnJlcT0wDQpbMjMzNzgu NjMzNjg0XSBtd2lmaWV4X3BjaWUgMDAwMDowMTowMC4wOiBtd2lmaWV4X2dldF9jZnA6DQpjYW5u b3QgZmluZCBjZnAgYnkgYmFuZCAyICAgICYgY2hhbm5lbD0xMyBmcmVxPTANCg0KTWF5YmUgdGhh dCdzIHJlbGF0ZWQgdG8gd2lmaSByZWdkb20sIHNpbmNlIHdpZmkgZGVmYXVsdCBhcmVhIHdhcw0K VVMgYW5kIGRpZG4ndCBzdXBwb3J0IDEyfjE0IGNoYW5uZWxzLg0KDQpBcyBGcmVxdWVuY2llczoN CiogMjQxMiBNSHogWzFdICgzMC4wIGRCbSkNCiogMjQxNyBNSHogWzJdICgzMC4wIGRCbSkNCiog MjQyMiBNSHogWzNdICgzMC4wIGRCbSkNCiogMjQyNyBNSHogWzRdICgzMC4wIGRCbSkNCiogMjQz MiBNSHogWzVdICgzMC4wIGRCbSkNCiogMjQzNyBNSHogWzZdICgzMC4wIGRCbSkNCiogMjQ0MiBN SHogWzddICgzMC4wIGRCbSkNCiogMjQ0NyBNSHogWzhdICgzMC4wIGRCbSkNCiogMjQ1MiBNSHog WzldICgzMC4wIGRCbSkNCiogMjQ1NyBNSHogWzEwXSAoMzAuMCBkQm0pDQoqIDI0NjIgTUh6IFsx MV0gKDMwLjAgZEJtKQ0KKiAyNDY3IE1IeiBbMTJdIChkaXNhYmxlZCkNCiogMjQ3MiBNSHogWzEz XSAoZGlzYWJsZWQpDQoqIDI0ODQgTUh6IFsxNF0gKGRpc2FibGVkKQ0KDQpTaWduZWQtb2ZmLWJ5 OiBDYWVzYXIgV2FuZyA8d3h0QHJvY2stY2hpcHMuY29tPg0KLS0tDQoNCiAgIGRyaXZlcnMvbmV0 L3dpcmVsZXNzL21hcnZlbGwvbXdpZmlleC9jZnAuYyB8IDIgKy0NCiAgIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9u ZXQvd2lyZWxlc3MvbWFydmVsbC9td2lmaWV4L2NmcC5jDQpiL2RyaXZlcnMvbmV0L3dpcmVsZXNz L21hcnZlbGwvbXdpZmlleC9jZnAuYw0KaW5kZXggMWZmMjIwNS4uNmUyOTk0MyAxMDA2NDQNCi0t LSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmlleC9jZnAuYw0KKysrIGIvZHJp dmVycy9uZXQvd2lyZWxlc3MvbWFydmVsbC9td2lmaWV4L2NmcC5jDQpAQCAtMzUwLDcgKzM1MCw3 IEBAIG13aWZpZXhfZ2V0X2NmcChzdHJ1Y3QgbXdpZmlleF9wcml2YXRlICpwcml2LCB1OA0KYmFu ZCwgdTE2IGNoYW5uZWwsIHUzMiBmcmVxKQ0KICAgCQl9DQogICAJfQ0KICAgCWlmIChpID09IHNi YW5kLT5uX2NoYW5uZWxzKSB7DQotCQltd2lmaWV4X2RiZyhwcml2LT5hZGFwdGVyLCBFUlJPUiwN CisJCW13aWZpZXhfZGJnKHByaXYtPmFkYXB0ZXIsIFdBUk4sDQogICAJCQkgICAgIiVzOiBjYW5u b3QgZmluZCBjZnAgYnkgYmFuZCAlZFx0Ig0KICAgCQkJICAgICImIGNoYW5uZWw9JWQgZnJlcT0l ZFxuIiwNCiAgIAkJCSAgICBfX2Z1bmNfXywgYmFuZCwgY2hhbm5lbCwgZnJlcSk7DQpJIGRvbid0 IHNlZSBob3cgdGhpcyBmaXhlcyBhbnl0aGluZywgY2FyZSB0byBleHBsYWluPyBBbmQgdGhlIHRp dGxlDQppcyBxdWl0ZSB2YWd1ZS4NClNvcnJ5IGZvciB0aGUgZGVzY3JpcHRpb24gbWF5YmUgdW5j bGVhci4NCkknbSBhc3N1bWluZyB0aGUgcHJpbnQgbG9nIGlzIGV4cGVjdGVkIGZvciBtYXJ2ZWwg d2lmaSBkcml2ZXIuIERvIHdlDQpzaG91bGQgdXNlICdXQVJOJyB0byBpbnN0ZWFkIG9mIHRoZSAn RVJST1InIGhlcmUuDQpCdXQgZG9lcyB0aGF0IG1ha2UgYW55IGZ1bmN0aW9uYWwgZGlmZmVyZW5j ZSwgaXNuJ3QgdGhlIHdhcm5pbmcgc3RpbGwNCnByaW50ZWQ/DQoNCg0KQXQgbGVhc3QsIHRoYXQg c2hvdWxkbid0IGJlIHByaW50ZWQgbG9nIGJ5IGRlZmF1bHQuICA6KQ0KDQppZiBJIHJlYWQgdGhl IGNvZGUgaXMgY29ycmVjdC4gVGhhdCBvbmx5IHRoZSBNU0cvRkFUQUwvRVJST1Igd2lsbA0Kb3V0 cHV0IGJ5IGRlZmF1bHQuDQoNCi8qKg0KICplbnVtIG13aWZpZXhfZGVidWdfbGV2ZWwgIC0gIG1h cnZlbGwgd2lmaSBkZWJ1ZyBsZXZlbCAgKi8gZW51bQ0KTVdJRklFWF9ERUJVR19MRVZFTCB7DQog ICAgTVdJRklFWF9EQkdfTVNHICAgICAgICA9IDB4MDAwMDAwMDEsDQogICAgTVdJRklFWF9EQkdf RkFUQUwgICAgPSAweDAwMDAwMDAyLA0KICAgIE1XSUZJRVhfREJHX0VSUk9SICAgID0gMHgwMDAw MDAwNCwNCiAgICBNV0lGSUVYX0RCR19EQVRBICAgID0gMHgwMDAwMDAwOCwNCiAgICBNV0lGSUVY X0RCR19DTUQgICAgICAgID0gMHgwMDAwMDAxMCwNCiAgICBNV0lGSUVYX0RCR19FVkVOVCAgICA9 IDB4MDAwMDAwMjAsDQogICAgTVdJRklFWF9EQkdfSU5UUiAgICA9IDB4MDAwMDAwNDAsDQogICAg TVdJRklFWF9EQkdfSU9DVEwgICAgPSAweDAwMDAwMDgwLA0KDQogICAgTVdJRklFWF9EQkdfTVBB X0QgICAgPSAweDAwMDA4MDAwLA0KICAgIE1XSUZJRVhfREJHX0RBVF9EICAgID0gMHgwMDAxMDAw MCwNCiAgICBNV0lGSUVYX0RCR19DTURfRCAgICA9IDB4MDAwMjAwMDAsDQogICAgTVdJRklFWF9E QkdfRVZUX0QgICAgPSAweDAwMDQwMDAwLA0KICAgIE1XSUZJRVhfREJHX0ZXX0QgICAgPSAweDAw MDgwMDAwLA0KICAgIE1XSUZJRVhfREJHX0lGX0QgICAgPSAweDAwMTAwMDAwLA0KDQogICAgTVdJ RklFWF9EQkdfRU5UUlkgICAgPSAweDEwMDAwMDAwLA0KICAgIE1XSUZJRVhfREJHX1dBUk4gICAg PSAweDIwMDAwMDAwLA0KICAgIE1XSUZJRVhfREJHX0lORk8gICAgPSAweDQwMDAwMDAwLA0KICAg IE1XSUZJRVhfREJHX0RVTVAgICAgPSAweDgwMDAwMDAwLA0KDQogICAgTVdJRklFWF9EQkdfQU5Z ICAgICAgICA9IDB4ZmZmZmZmZmYNCn07DQoNCiNkZWZpbmUgTVdJRklFWF9ERUZBVUxUX0RFQlVH X01BU0sgICAgKE1XSUZJRVhfREJHX01TRyB8IFwNCiAgICAgICAgICAgICAgICAgICAgTVdJRklF WF9EQkdfRkFUQUwgfCBcDQogICAgICAgICAgICAgICAgICAgIE1XSUZJRVhfREJHX0VSUk9SKQ0K DQpIZWgsIG1ha2VzIG1vcmUgc2Vuc2Ugbm93IDopIEJ1dCB5b3Ugc3RpbGwgc2hvdWxkIGltcHJv dmUgdGhlIHRpdGxlIGFuZA0KZXhwbGFpbiBpbiB0aGUgY29tbWl0IGxvZyB0aGF0IFdBUk4gbGV2 ZWwgaXMgbm90IHByaW50ZWQgYnkgZGVmYXVsdC4NCg0KQnV0IGJlZm9yZSB5b3Ugc3VibWl0IHYy IGxldCdzIHdhaXQgd2hhdCBNYXJ2ZWxsIHNheXMgYWJvdXQgdGhpcy4NCg0KLS0NCkthbGxlIFZh bG8NCg0K ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mwifiex: fixes the trivial print 2017-06-14 10:23 ` Xinming Hu @ 2017-06-14 11:11 ` Caesar Wang 0 siblings, 0 replies; 9+ messages in thread From: Caesar Wang @ 2017-06-14 11:11 UTC (permalink / raw) To: Xinming Hu Cc: Kalle Valo, Zhiyuan Yang, Cathy Luo, amitkarwar@gmail.com, Nishant Sarmukadam, Ganapathi Bhat, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, jeffy.chen@rock-chips.com 在 2017年06月14日 18:23, Xinming Hu 写道: > Hi Caesar, > > It proved to be a feature to get better scan result from overlapping channel, introduced in > > commit 1b499cb72f26bbf44f2fa158c2d1487730aae96a > Author: Amitkumar Karwar <akarwar@marvell.com> > Date: Sun Apr 24 23:49:51 2016 -0700 > > mwifiex: disable channel filtering feature in firmware > > As 2.4Ghz channels are overlapping, sometimes AP responds to > probe request even if it's operating on neighbouring channel. > Currently firmware drops those scan entries, as current channel > doesn't match with APs channel. > > This patch enables MWIFIEX_DISABLE_CHAN_FILT flag in scan > command to disable the feature so that better scan results > will be received in 2.4Ghz band. > > As I can see, even there could be AP from overlapping channel (might be 12/13/14 in this case), it will be filtered depend on reg domain rules > > if (ch->flags & IEEE80211_CHAN_DISABLED) > continue; > > so it should not been an ERROR. WARN looks fine to me. > you can add me acked-by in v2. Okay, thanks for explanation and having a look at it. -Caesar > > > Regards, > Simon > From: Caesar Wang [mailto:wxt@rock-chips.com] > Sent: 2017年6月13日 18:52 > To: Xinming Hu; Kalle Valo; Zhiyuan Yang; Cathy Luo > Cc: amitkarwar@gmail.com; Nishant Sarmukadam; Ganapathi Bhat; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; briannorris@chromium.org; jeffy.chen@rock-chips.com; Ganapathi Bhat > Subject: [EXT] Re: [PATCH] mwifiex: fixes the trivial print > > External Email > ________________________________________ > Hi Xinming, > As issue tracked on https://partnerissuetracker.corp.google.com/u/2/issues/62122843 > > > 在 2017年06月13日 17:51, Xinming Hu 写道: > Hi Caesar, > > The original log in google issue tracker show there exist AP in channel 13 after periodically scan. > Per my understand, if reg domain is set to US, channel 12/13/14 will not get chance to scan. (test using iw/wpa_supplicant). > I am curious about whether there are any diff from upper layer. > > As a test, you can print the scan channel list, as below: > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index a7593aa..a289818 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -2572,6 +2572,7 @@ static int mwifiex_set_ibss_params(struct mwifiex_private *priv, > MWIFIEX_USER_SCAN_CHAN_MAX); i++) { > chan = request->channels[i]; > user_scan_cfg->chan_list[i].chan_number = chan->hw_value; > + pr_err("chan->hw_value = %d", chan->hw_value); > user_scan_cfg->chan_list[i].radio_type = chan->band; > > if ((chan->flags & IEEE80211_CHAN_NO_IR) || !request->n_ssids) > > The below as the required log: > localhost / # [ 46.760997] mwifiex: chan->hw_value = 1 > [ 46.764878] mwifiex: chan->hw_value = 2 > [ 46.768765] mwifiex: chan->hw_value = 3 > [ 46.772625] mwifiex: chan->hw_value = 4 > [ 46.776608] mwifiex: chan->hw_value = 5 > [ 46.780485] mwifiex: chan->hw_value = 6 > [ 46.784384] mwifiex: chan->hw_value = 7 > [ 46.788252] mwifiex: chan->hw_value = 8 > [ 46.792185] mwifiex: chan->hw_value = 9 > [ 46.796036] mwifiex: chan->hw_value = 10 > [ 46.799978] mwifiex: chan->hw_value = 11 > [ 46.803908] mwifiex: chan->hw_value = 38 > [ 46.807847] mwifiex: chan->hw_value = 42 > [ 46.811786] mwifiex: chan->hw_value = 46 > [ 46.815722] mwifiex: chan->hw_value = 36 > [ 46.819646] mwifiex: chan->hw_value = 40 > [ 46.823577] mwifiex: chan->hw_value = 44 > [ 46.827503] mwifiex: chan->hw_value = 48 > [ 46.831440] mwifiex: chan->hw_value = 52 > [ 46.835363] mwifiex: chan->hw_value = 56 > [ 46.839287] mwifiex: chan->hw_value = 60 > [ 46.843205] mwifiex: chan->hw_value = 64 > [ 46.847129] mwifiex: chan->hw_value = 100 > [ 46.851134] mwifiex: chan->hw_value = 104 > [ 46.855150] mwifiex: chan->hw_value = 108 > [ 46.859155] mwifiex: chan->hw_value = 112 > [ 46.863168] mwifiex: chan->hw_value = 116 > [ 46.867175] mwifiex: chan->hw_value = 120 > [ 46.871186] mwifiex: chan->hw_value = 124 > [ 46.875196] mwifiex: chan->hw_value = 128 > [ 46.879208] mwifiex: chan->hw_value = 132 > [ 46.883214] mwifiex: chan->hw_value = 136 > [ 46.887224] mwifiex: chan->hw_value = 140 > [ 46.891230] mwifiex: chan->hw_value = 149 > [ 46.895241] mwifiex: chan->hw_value = 153 > [ 46.899246] mwifiex: chan->hw_value = 157 > [ 46.903256] mwifiex: chan->hw_value = 161 > [ 46.907262] mwifiex: chan->hw_value = 165 > [ 47.394176] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: cannot find cfp by band 2 & channel=12 freq=0 > > -Caesar > > > Regards, > Simon > > -----Original Message----- > From: Kalle Valo [mailto:kvalo@codeaurora.org] > Sent: 2017年6月13日 15:53 > To: Caesar Wang > Cc: amitkarwar@gmail.com; Xinming Hu; Nishant Sarmukadam; Ganapathi > Bhat; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; briannorris@chromium.org; > jeffy.chen@rock-chips.com > Subject: [EXT] Re: [PATCH] mwifiex: fixes the trivial print > > External Email > > ---------------------------------------------------------------------- > Caesar Wang <wxt@rock-chips.com> writes: > > 在 2017年06月13日 15:04, Kalle Valo 写道: > Caesar Wang <wxt@rock-chips.com> writes: > > Kalle, > > 在 2017年06月13日 14:28, Kalle Valo 写道: > Caesar Wang <wxt@rock-chips.com> writes: > > We have always met the unused log be printed as following. > > ... > [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: > cannot find cfp by band 2 & channel=13 freq=0 > [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: > cannot find cfp by band 2 & channel=13 freq=0 > > Maybe that's related to wifi regdom, since wifi default area was > US and didn't support 12~14 channels. > > As Frequencies: > * 2412 MHz [1] (30.0 dBm) > * 2417 MHz [2] (30.0 dBm) > * 2422 MHz [3] (30.0 dBm) > * 2427 MHz [4] (30.0 dBm) > * 2432 MHz [5] (30.0 dBm) > * 2437 MHz [6] (30.0 dBm) > * 2442 MHz [7] (30.0 dBm) > * 2447 MHz [8] (30.0 dBm) > * 2452 MHz [9] (30.0 dBm) > * 2457 MHz [10] (30.0 dBm) > * 2462 MHz [11] (30.0 dBm) > * 2467 MHz [12] (disabled) > * 2472 MHz [13] (disabled) > * 2484 MHz [14] (disabled) > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > --- > > drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c > b/drivers/net/wireless/marvell/mwifiex/cfp.c > index 1ff2205..6e29943 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfp.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c > @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 > band, u16 channel, u32 freq) > } > } > if (i == sband->n_channels) { > - mwifiex_dbg(priv->adapter, ERROR, > + mwifiex_dbg(priv->adapter, WARN, > "%s: cannot find cfp by band %d\t" > "& channel=%d freq=%d\n", > __func__, band, channel, freq); > I don't see how this fixes anything, care to explain? And the title > is quite vague. > Sorry for the description maybe unclear. > I'm assuming the print log is expected for marvel wifi driver. Do we > should use 'WARN' to instead of the 'ERROR' here. > But does that make any functional difference, isn't the warning still > printed? > > > At least, that shouldn't be printed log by default. :) > > if I read the code is correct. That only the MSG/FATAL/ERROR will > output by default. > > /** > *enum mwifiex_debug_level - marvell wifi debug level */ enum > MWIFIEX_DEBUG_LEVEL { > MWIFIEX_DBG_MSG = 0x00000001, > MWIFIEX_DBG_FATAL = 0x00000002, > MWIFIEX_DBG_ERROR = 0x00000004, > MWIFIEX_DBG_DATA = 0x00000008, > MWIFIEX_DBG_CMD = 0x00000010, > MWIFIEX_DBG_EVENT = 0x00000020, > MWIFIEX_DBG_INTR = 0x00000040, > MWIFIEX_DBG_IOCTL = 0x00000080, > > MWIFIEX_DBG_MPA_D = 0x00008000, > MWIFIEX_DBG_DAT_D = 0x00010000, > MWIFIEX_DBG_CMD_D = 0x00020000, > MWIFIEX_DBG_EVT_D = 0x00040000, > MWIFIEX_DBG_FW_D = 0x00080000, > MWIFIEX_DBG_IF_D = 0x00100000, > > MWIFIEX_DBG_ENTRY = 0x10000000, > MWIFIEX_DBG_WARN = 0x20000000, > MWIFIEX_DBG_INFO = 0x40000000, > MWIFIEX_DBG_DUMP = 0x80000000, > > MWIFIEX_DBG_ANY = 0xffffffff > }; > > #define MWIFIEX_DEFAULT_DEBUG_MASK (MWIFIEX_DBG_MSG | \ > MWIFIEX_DBG_FATAL | \ > MWIFIEX_DBG_ERROR) > > Heh, makes more sense now :) But you still should improve the title and > explain in the commit log that WARN level is not printed by default. > > But before you submit v2 let's wait what Marvell says about this. > > -- > Kalle Valo > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-06-14 11:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 11:40 [PATCH] mwifiex: fixes the trivial print Caesar Wang
2017-06-13 6:28 ` Kalle Valo
2017-06-13 6:54 ` Caesar Wang
2017-06-13 7:04 ` Kalle Valo
2017-06-13 7:42 ` Caesar Wang
2017-06-13 7:53 ` Kalle Valo
2017-06-13 9:51 ` Xinming Hu
[not found] ` <cf947dd3-e3a9-e940-fa15-393c9d952f32@rock-chips.com>
2017-06-14 10:23 ` Xinming Hu
2017-06-14 11:11 ` Caesar Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).