From: Jakub Sitnicki <jsitnicki@gmail.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Larry.Finger@lwfinger.net, linux-wireless@vger.kernel.org
Subject: Re: [RFC 13/16] rtl8xxxu: Make set_tx_power a chip-type-dependent operation
Date: Fri, 23 Oct 2015 23:17:28 +0200 [thread overview]
Message-ID: <87mvv9e13r.fsf@frog.home> (raw)
In-Reply-To: <wrfjtwplug7v.fsf@redhat.com>
On Wed, Oct 21, 2015 at 04:07 AM CEST, Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
> Jakub Sitnicki <jsitnicki@gmail.com> writes:
>> Preparatory step for adding support for RTL8188EU chips.
>>
>> Signed-off-by: Jakub Sitnicki <jsitnicki@gmail.com>
>> ---
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 6 ++++--
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 +
>> 2 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
>> index 83cdc2a..ecda799 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
>> @@ -4223,7 +4223,7 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw)
>> /*
>> * Start out with default power levels for channel 6, 20MHz
>> */
>> - rtl8723a_set_tx_power(priv, 1, false);
>> + priv->fops->set_tx_power(priv, 1, false);
>>
>> /* Let the 8051 take control of antenna setting */
>> val8 = rtl8xxxu_read8(priv, REG_LEDCFG2);
>> @@ -5207,7 +5207,7 @@ static int rtl8xxxu_config(struct ieee80211_hw *hw, u32 changed)
>>
>> channel = hw->conf.chandef.chan->hw_value;
>>
>> - rtl8723a_set_tx_power(priv, channel, ht40);
>> + priv->fops->set_tx_power(priv, channel, ht40);
>>
>> rtl8723au_config_channel(hw);
>> }
>> @@ -5781,6 +5781,7 @@ static struct rtl8xxxu_fileops rtl8723au_fops = {
>> .parse_efuse = rtl8723au_parse_efuse,
>> .load_firmware = rtl8723au_load_firmware,
>> .power_on = rtl8723au_power_on,
>> + .set_tx_power = rtl8723a_set_tx_power,
>> .efuse_len = EFUSE_REAL_CONTENT_LEN_8723A,
>> .writeN_block_size = 1024,
>> };
>> @@ -5789,6 +5790,7 @@ static struct rtl8xxxu_fileops rtl8192cu_fops = {
>> .parse_efuse = rtl8192cu_parse_efuse,
>> .load_firmware = rtl8192cu_load_firmware,
>> .power_on = rtl8192cu_power_on,
>> + .set_tx_power = rtl8723a_set_tx_power,
>> .efuse_len = EFUSE_REAL_CONTENT_LEN_8723A,
>> .writeN_block_size = 128,
>> };
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
>> index 1a767eb..427eb7e 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
>> @@ -679,6 +679,7 @@ struct rtl8xxxu_fileops {
>> int (*parse_efuse) (struct rtl8xxxu_priv *priv);
>> int (*load_firmware) (struct rtl8xxxu_priv *priv);
>> int (*power_on) (struct rtl8xxxu_priv *priv);
>> + void (*set_tx_power) (struct rtl8xxxu_priv *priv, int channel, bool ht40);
>> int efuse_len;
>> int writeN_block_size;
>> };
>
> Lets not add function pointers before we actually know we have a need
> for them.
OK, will hold on to this patch in my queue.
-Jakub
next prev parent reply other threads:[~2015-10-23 21:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 6:45 [RFC 00/16] rtl8xxxu: eFUSE parsing for RTL8188EU chips Jakub Sitnicki
2015-10-20 6:45 ` [RFC 01/16] rtl8xxxu: Treat REG_9346CR as an 8-bit wide register Jakub Sitnicki
2015-10-21 0:29 ` Jes Sorensen
2015-10-23 5:38 ` Jakub Sitnicki
2015-10-20 6:45 ` [RFC 02/16] rtl8xxxu: Use REG_EFUSE_TEST register only on multifunctional devices Jakub Sitnicki
2015-10-21 0:57 ` Jes Sorensen
2015-10-23 5:45 ` Jakub Sitnicki
2015-10-20 6:45 ` [RFC 03/16] rtl8xxxu: Don't check for illegal offset when reading from efuse Jakub Sitnicki
2015-10-21 1:07 ` Jes Sorensen
2015-10-20 6:45 ` [RFC 04/16] rtl8xxxu: Skip disabled efuse words early Jakub Sitnicki
2015-10-21 1:09 ` Jes Sorensen
2015-10-20 6:45 ` [RFC 05/16] rtl8xxxu: Unbreak a user-visible string Jakub Sitnicki
2015-10-21 1:46 ` Jes Sorensen
2015-10-23 5:54 ` Jakub Sitnicki
2015-10-23 15:38 ` Jes Sorensen
2015-10-20 6:45 ` [RFC 06/16] rtl8xxxu: rtl8723au: Introduce a pointer to efuse Jakub Sitnicki
2015-10-21 1:52 ` Jes Sorensen
2015-10-20 6:45 ` [RFC 07/16] rtl8xxxu: rtl8192cu: " Jakub Sitnicki
2015-10-20 6:45 ` [RFC 08/16] rtl8xxxu: Extract TX power fields from struct rtl8xxu_priv Jakub Sitnicki
2015-10-21 1:58 ` Jes Sorensen
2015-10-23 21:16 ` Jakub Sitnicki
2015-10-26 17:40 ` Jes Sorensen
2015-10-20 6:45 ` [RFC 09/16] rtl8xxxu: Rename struct struct rtl8723au_tx_power fields Jakub Sitnicki
2015-10-20 6:45 ` [RFC 10/16] rtl8xxxu: Rename struct rtl8723au_idx Jakub Sitnicki
2015-10-21 2:00 ` Jes Sorensen
2015-10-20 6:45 ` [RFC 11/16] rtl8xxxu: Make efuse content length a parameter Jakub Sitnicki
2015-10-21 2:01 ` Jes Sorensen
2015-10-20 6:45 ` [RFC 12/16] rtl8xxxu: Prepare to have more than one kind of struct *_tx_power Jakub Sitnicki
2015-10-20 6:45 ` [RFC 13/16] rtl8xxxu: Make set_tx_power a chip-type-dependent operation Jakub Sitnicki
2015-10-21 2:07 ` Jes Sorensen
2015-10-23 21:17 ` Jakub Sitnicki [this message]
2015-10-20 6:45 ` [RFC 14/16] rtl8xxxu: Introduce a device agnostic constant for efuse map length Jakub Sitnicki
2015-10-21 2:03 ` Jes Sorensen
2015-10-20 6:45 ` [RFC 15/16] rtl8xxxu: rtl8188eu: Add stubbed fileops and chip-specific constants Jakub Sitnicki
2015-10-20 6:45 ` [RFC 16/16] rtl8xxxu: rtl8188eu: Implement parse_efuse() Jakub Sitnicki
2015-10-21 2:15 ` Jes Sorensen
2015-10-23 21:52 ` Jakub Sitnicki
2015-10-26 17:45 ` Jes Sorensen
2015-11-02 8:21 ` [PATCH] rtl8xxxu: rtl8192eu: Map out EFUSE TX power area Jakub Sitnicki
2015-11-10 21:57 ` Jes Sorensen
2015-10-21 0:29 ` [RFC 00/16] rtl8xxxu: eFUSE parsing for RTL8188EU chips Jes Sorensen
2015-10-23 5:24 ` Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvv9e13r.fsf@frog.home \
--to=jsitnicki@gmail.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).