From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
brcm80211 development <brcm80211-dev-list@broadcom.com>
Subject: Re: [PATCH 3/4] bcma: support bringing up bus hosted on PCIe Gen 2
Date: Fri, 06 Feb 2015 08:56:18 +0200 [thread overview]
Message-ID: <87mw4rplyl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CACna6rwarKekDeR6YL73HcErmu1WGENcN7wVq0gMUEyHq0HekA@mail.gmail.com> ("Rafał Miłecki"'s message of "Sat, 31 Jan 2015 00:08:50 +0100")
Rafał Miłecki <zajec5@gmail.com> writes:
>>> +void bcma_core_pcie2_up(struct bcma_drv_pcie2 *pcie2)
>>> +{
>>> + struct bcma_bus *bus = pcie2->core->bus;
>>> + struct pci_dev *dev = bus->host_pci;
>>> +
>>> + pcie_capability_clear_and_set_word(dev, PCI_EXP_DEVCTL,
>>> + PCI_EXP_DEVCTL_READRQ,
>>> + pcie2->reqsize);
>>
>> Use pcie_set_readrq() if it is needed.
>
> What do you mean by "if needed"? Is there anything wrong?
So what's the conclusion? Can I apply these?
--
Kalle Valo
next prev parent reply other threads:[~2015-02-06 6:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 17:22 [PATCH 1/4] bcma: add helpers bringing PCIe hosted bus up / down Rafał Miłecki
2015-01-30 17:22 ` [PATCH 2/4] bcma: change IRQ control function to accept bus as an argument Rafał Miłecki
2015-01-30 17:22 ` [PATCH 3/4] bcma: support bringing up bus hosted on PCIe Gen 2 Rafał Miłecki
2015-01-30 19:59 ` Hauke Mehrtens
2015-01-30 23:08 ` Rafał Miłecki
2015-02-06 6:56 ` Kalle Valo [this message]
2015-02-08 14:12 ` Hauke Mehrtens
2015-01-30 17:22 ` [PATCH 4/4] bcma: enable support for PCIe Gen 2 host devices Rafał Miłecki
2015-02-08 15:31 ` [PATCH V2 1/4] bcma: add helpers bringing PCIe hosted bus up / down Rafał Miłecki
2015-02-08 15:31 ` [PATCH V2 2/4] bcma: change IRQ control function to accept bus as an argument Rafał Miłecki
2015-02-08 15:31 ` [PATCH V2 3/4] bcma: support bringing up bus hosted on PCIe Gen 2 Rafał Miłecki
2015-02-08 15:31 ` [PATCH V2 4/4] bcma: enable support for PCIe Gen 2 host devices Rafał Miłecki
2015-02-08 16:11 ` [PATCH V3 1/4] bcma: add helpers bringing PCIe hosted bus up / down Rafał Miłecki
2015-02-08 16:11 ` [PATCH V3 2/4] bcma: change IRQ control function to accept bus as an argument Rafał Miłecki
2015-02-08 16:11 ` [PATCH V3 3/4] bcma: support bringing up bus hosted on PCIe Gen 2 Rafał Miłecki
2015-02-08 16:11 ` [PATCH V3 4/4] bcma: enable support for PCIe Gen 2 host devices Rafał Miłecki
2015-03-02 15:00 ` [PATCH V3 1/4] bcma: add helpers bringing PCIe hosted bus up / down Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw4rplyl.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).