From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org,
Troy Tan <troy_tan@realsil.com.cn>,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/6] rtlwifi: btcoexist: Add routines for RTL8812AE - all configs
Date: Fri, 23 Jan 2015 22:12:30 +0200 [thread overview]
Message-ID: <87mw59jlxt.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1422033044-7461-6-git-send-email-Larry.Finger@lwfinger.net> (Larry Finger's message of "Fri, 23 Jan 2015 11:10:43 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> From: Troy Tan <troy_tan@realsil.com.cn>
>
> This patch adds the routines used for all antenna configurations.
>
> Signed-off-by: Troy Tan <troy_tan@realsil.com.cn>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
The commit log is REALLY vague...
> +static u8 rtl_btcoex_create_kernel_socket(struct rtl_priv *rtlpriv,
> + u8 is_invite)
> +{
> + struct bt_coex_info *pcoex_info = &rtlpriv->coex_info;
> + s8 kernel_socket_err;
> +
> + BTC_PRINT(BTC_MSG_SOCKET, SOCKET_CRITICAL,
> + "%s CONNECT_PORT %d\n", __func__, CONNECT_PORT);
> +
> + if (!pcoex_info) {
> + BTC_PRINT(BTC_MSG_SOCKET, SOCKET_CRITICAL, "coex_info: NULL\n");
> + return _FAIL;
> + }
> +
> + kernel_socket_err = sock_create(PF_INET, SOCK_DGRAM, 0,
> + &pcoex_info->udpsock);
> + BTC_PRINT(BTC_MSG_SOCKET, SOCKET_CRITICAL,
> + "binding socket, err = %d\n", kernel_socket_err);
> +
> + if (kernel_socket_err < 0) {
> + BTC_PRINT(BTC_MSG_SOCKET, SOCKET_CRITICAL,
> + "Error during creation of socket error:%d\n",
> + kernel_socket_err);
> + return _FAIL;
> + }
> + memset(&pcoex_info->sin, 0, sizeof(pcoex_info->sin));
> + pcoex_info->sin.sin_family = AF_INET;
> + pcoex_info->sin.sin_port = htons(CONNECT_PORT);
> + pcoex_info->sin.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
...and then I see stuff like this. What an earth does this do?
--
Kalle Valo
next prev parent reply other threads:[~2015-01-23 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 17:10 [PATCH 0/6] Some changes for rtlwifi Larry Finger
2015-01-23 17:10 ` [PATCH 1/6] rtlwifi: Change logging level for key change Larry Finger
2015-01-23 17:10 ` [PATCH 2/6] rtlwifi: btcoexist: Remove typedef statements Larry Finger
2015-01-23 17:10 ` [PATCH 3/6] rtlwifi: btcoexist: Add routines for RTL8812AE with single antenna Larry Finger
2015-01-23 20:06 ` Kalle Valo
2015-01-23 20:24 ` Larry Finger
2015-01-23 17:10 ` [PATCH 4/6 for NEXT] rtlwifi: btcoexist: Add routines for RTL8812AE with dual antennae Larry Finger
2015-01-23 17:10 ` [PATCH 5/6] rtlwifi: btcoexist: Add routines for RTL8812AE - all configs Larry Finger
2015-01-23 20:12 ` Kalle Valo [this message]
2015-01-23 17:10 ` [PATCH 6/6] rtlwifi: btcoexist: Enable new routines for RTL8812AE Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw59jlxt.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=troy_tan@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).