From: Kalle Valo <kvalo@codeaurora.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-wireless@vger.kernel.org,
Brett Rudley <brudley@broadcom.com>,
Arend van Spriel <arend@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
Christophe Prigent <christophe.prigent@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: Do not crash if platform data is not populated
Date: Wed, 24 Dec 2014 15:29:13 +0200 [thread overview]
Message-ID: <87mw6d9nx2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1419346112-173303-1-git-send-email-mika.westerberg@linux.intel.com> (Mika Westerberg's message of "Tue, 23 Dec 2014 16:48:32 +0200")
Mika Westerberg <mika.westerberg@linux.intel.com> writes:
> The driver looks for pdata->oob_irq_supported to find out if wowl can be
> supported. However, not all platforms populate pdata in which case we crash
> the kernel because of NULL pointer dereference.
>
> Fixes: 330b4e4be937 ("brcmfmac: Add wowl support for SDIO devices.")
> Reported-by: Christophe Prigent <christophe.prigent@intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks, applied to wireless-drivers.git.
--
Kalle Valo
prev parent reply other threads:[~2014-12-24 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 14:48 [PATCH] brcmfmac: Do not crash if platform data is not populated Mika Westerberg
2014-12-23 15:37 ` Arend van Spriel
2014-12-23 15:47 ` Mika Westerberg
2014-12-23 15:59 ` Arend van Spriel
2014-12-23 17:00 ` Kalle Valo
2014-12-23 17:33 ` Arend van Spriel
2014-12-24 13:29 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw6d9nx2.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=christophe.prigent@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).