Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Julien Massot <jmassot@aldebaran-robotics.com>
Cc: <ath6kl-devel@qca.qualcomm.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] ath6kl: cold reset target after host warm boot
Date: Mon, 11 Mar 2013 13:11:07 +0200	[thread overview]
Message-ID: <87mwuachtg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CADGp=QeRNuJLeDBWPH=z89R18-sEMy6qYsfaseyLG9qR+M4AbQ@mail.gmail.com> (Julien Massot's message of "Mon, 11 Mar 2013 11:26:07 +0100")

Julien Massot <jmassot@aldebaran-robotics.com> writes:

>> Julien reported that ar6004 usb device fails to initialise
>> after host has been rebooted and power is still on for the ar6004 device. He
>> found out that doing a cold reset fixes the issue.
>>
>> I wasn't sure what would be the best way to detect if target needs a reset so I
>> settled on checking a timeout from htc_wait_recv_ctrl_message().
>>
>> Reported-by: Julien Massot <jmassot@aldebaran-robotics.com>
>> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
>> ---
>
> This patch fix the issue, now my adapter works after a soft reboot.
> The log are also better: (here is what happen on soft reboot)
>
> [   17.328029] ath6kl: htc pipe control receive timeout!
> [   17.328033] ath6kl: htc wait target timed out, resetting device
> [   17.332178] ath6kl: Failed to start hardware: -110
> [   17.332208] ath6kl: Failed to init ath6kl core: -110
> [   17.332270] ath6kl_usb: probe of 2-1:1.0 failed with error -110
> [   17.332306] usbcore: registered new interface driver ath6kl_usb
> [   19.040315] ath6kl: ar6004 hw 1.3 usb fw 3.5.0.2356\x01 api 3

Oh, I also need to fix that \x01 in the firmware version, the null
termination is incorrect. But this is a separate issue.

> Tested-by: Julien Massot <jmassot@aldebaran-robotics.com>

Thank you. I add that to the patch.

-- 
Kalle Valo

  reply	other threads:[~2013-03-11 11:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09 10:01 [PATCH v2 0/3] ath6kl: fix usb warm reboot and cleanups Kalle Valo
2013-03-09 10:01 ` [PATCH v2 1/3] ath6kl: cleanup ath6kl_reset_device() Kalle Valo
2013-03-09 10:01 ` [PATCH v2 2/3] ath6kl: fix usb related error handling and warnings Kalle Valo
2013-03-09 10:01 ` [PATCH v2 3/3] ath6kl: cold reset target after host warm boot Kalle Valo
2013-03-11 10:26   ` Julien Massot
2013-03-11 11:11     ` Kalle Valo [this message]
2013-03-12 16:26       ` Mohammed Shafi Shajakhan
2013-03-18 11:40 ` [PATCH v2 0/3] ath6kl: fix usb warm reboot and cleanups Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwuachtg.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath6kl-devel@qca.qualcomm.com \
    --cc=jmassot@aldebaran-robotics.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox