From: Kalle Valo <kvalo@adurom.com>
To: Yogesh Ashok Powar <yogeshp@marvell.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH 2/2] mwl8k: setting IEEE80211_HW_CRYPTO_ENABLED for AP mode
Date: Fri, 15 Apr 2011 10:00:53 +0300 [thread overview]
Message-ID: <87mxjshuca.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20110415045430.GA11530@hertz.marvell.com> (Yogesh Ashok Powar's message of "Fri\, 15 Apr 2011 10\:24\:38 +0530")
Yogesh Ashok Powar <yogeshp@marvell.com> writes:
> For AP mode, driver sets IEEE80211_HW_CRYPTO_ENABLED hardware flag to avoid
> mac80211 reserving tail room space for crypto suite.
A small style issue:
> + /* This is needed to avoid tailroom calculations */
> + hw->flags |= priv->ap_fw ? IEEE80211_HW_CRYPTO_ENABLED : 0;
Why not just:
if (priv->ap_fw)
hw->flags |= IEEE80211_HW_CRYPTO_ENABLED
A lot easier to read.
--
Kalle Valo
prev parent reply other threads:[~2011-04-15 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 4:54 [PATCH 2/2] mwl8k: setting IEEE80211_HW_CRYPTO_ENABLED for AP mode Yogesh Ashok Powar
2011-04-15 7:00 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxjshuca.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=buytenh@wantstofly.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).