From: Kalle Valo <kalle.valo@iki.fi>
To: "tom.leiming\@gmail.com" <tom.leiming@gmail.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"johannes\@sipsolutions.net" <johannes@sipsolutions.net>
Subject: Re: [PATCH] mac80211: fix memory leak in ieee80211_send_probe_req
Date: Fri, 15 Jan 2010 16:36:44 +0200 [thread overview]
Message-ID: <87my0fsadf.fsf@purkki.valot.fi> (raw)
In-Reply-To: <87fx67qwmg.fsf@nokia.com> (Kalle Valo's message of "Fri\, 15 Jan 2010 16\:19\:03 +0200")
Kalle Valo <kalle.valo@iki.fi> writes:
> "ext tom.leiming@gmail.com" <tom.leiming@gmail.com> writes:
>
>> From: Ming Lei <tom.leiming@gmail.com>
>>
>> This patch fixes memory leak in ieee80211_send_probe_req, which
>> is introduced in 7c12ce8b854df346388ea56d684784e3484012cf:
>>
>> mac80211: use Probe Request template when sending a direct scan
>
[...]
>> @@ -1028,6 +1028,7 @@ void ieee80211_send_probe_req(struct ieee80211_sub_if_data *sdata, u8 *dst,
>>
>> IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT;
>> ieee80211_tx_skb(sdata, skb);
>> + kfree(buf);
>
> Better to use dev_kfree_skb() here.
I don't know what I was thinking when I sent the previous email :)
After second look, this looks good.
Reviewed-by: Kalle Valo <kalle.valo@nokia.com>
--
Kalle Valo
prev parent reply other threads:[~2010-01-15 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 13:44 [PATCH] mac80211: fix memory leak in ieee80211_send_probe_req tom.leiming
2010-01-15 14:19 ` Kalle Valo
2010-01-15 14:36 ` Ming Lei
2010-01-15 14:53 ` Kalle Valo
2010-01-15 14:36 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87my0fsadf.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox