linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fixes compile error with CONFIG_PM=n
@ 2009-05-01 11:12 Hauke Mehrtens
  2009-05-01 13:26 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2009-05-01 11:12 UTC (permalink / raw)
  To: chunkeey; +Cc: linux-wireless, Hauke Mehrtens

/drivers/net/wireless/p54/p54usb.c: In function 'p54u_probe':
/drivers/net/wireless/p54/p54usb.c:923: error: 'struct usb_device' has no member named 'reset_resume'

In the struct usb_device the reset_resume attribute is only available when CONFIG_PM is defined.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/net/wireless/p54/p54usb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb.c
index ec6c954..f40c0f4 100644
--- a/drivers/net/wireless/p54/p54usb.c
+++ b/drivers/net/wireless/p54/p54usb.c
@@ -919,9 +919,11 @@ static int __devinit p54u_probe(struct usb_interface *intf,
 	priv->common.open = p54u_open;
 	priv->common.stop = p54u_stop;
 	if (recognized_pipes < P54U_PIPE_NUMBER) {
+#ifdef CONFIG_PM
 		/* ISL3887 needs a full reset on resume */
 		udev->reset_resume = 1;
 		err = p54u_device_reset(dev);
+#endif
 
 		priv->hw_type = P54U_3887;
 		dev->extra_tx_headroom += sizeof(struct lm87_tx_hdr);
-- 
1.6.2.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fixes compile error with CONFIG_PM=n
  2009-05-01 11:12 [PATCH] Fixes compile error with CONFIG_PM=n Hauke Mehrtens
@ 2009-05-01 13:26 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2009-05-01 13:26 UTC (permalink / raw)
  To: Hauke Mehrtens; +Cc: chunkeey, linux-wireless

Hauke Mehrtens <hauke@hauke-m.de> writes:

> /drivers/net/wireless/p54/p54usb.c: In function 'p54u_probe':
> /drivers/net/wireless/p54/p54usb.c:923: error: 'struct usb_device' has no member named 'reset_resume'
>
> In the struct usb_device the reset_resume attribute is only available when CONFIG_PM is defined.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

About the commit log, the title should contain the component, something
like this:

p54: fix reset_resume compile error with CONFIG_PM=n

Also please line wrap the commit log, 72 chars is a good width.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-01 13:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-01 11:12 [PATCH] Fixes compile error with CONFIG_PM=n Hauke Mehrtens
2009-05-01 13:26 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).