From: Kalle Valo <kalle.valo@nokia.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: validate SIOCSIWPOWER arguments better
Date: Wed, 07 Jan 2009 16:51:05 +0200 [thread overview]
Message-ID: <87mye35fvq.fsf@nokia.com> (raw)
In-Reply-To: <1231261955.3654.0.camel@johannes> (ext Johannes Berg's message of "Tue\, 06 Jan 2009 18\:12\:35 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> Don't accept any arguments we don't handle,
Makes sense to me. wrq->disabled case is not checked because of the
ugly goto, but at least for me that looks ok.
> and return error codes instead of using an uninitialised stack
> value.
You refer to ps variable here, right? Yeah, I wrote that. Sorry.
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Kalle Valo <kalle.valo@nokia.com>
--
Kalle Valo
prev parent reply other threads:[~2009-01-07 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 17:12 [PATCH] mac80211: validate SIOCSIWPOWER arguments better Johannes Berg
2009-01-07 14:51 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mye35fvq.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).