From: Kalle Valo <kalle.valo@nokia.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC v3 4/4] mac80211: move dynamic_ps_timeout to hw.conf
Date: Sat, 29 Nov 2008 09:00:03 +0200 [thread overview]
Message-ID: <87myfj10gc.fsf@nokia.com> (raw)
In-Reply-To: <1227910693.3543.7.camel@johannes.berg> (ext Johannes Berg's message of "Fri\, 28 Nov 2008 23\:18\:13 +0100")
"Johannes Berg" <johannes@sipsolutions.net> writes:
> On Fri, 2008-11-28 at 21:49 +0200, Kalle Valo wrote:
>> --- a/include/net/mac80211.h
>> +++ b/include/net/mac80211.h
>> @@ -560,6 +560,7 @@ struct ieee80211_conf {
>>
>> u16 listen_interval;
>> bool radio_enabled;
>> + int dynamic_ps_timeout;
>
> Same here, add documentation please;
I will.
> also, I think you need to call the hw_config call when this changes
> so drivers can upload the new value to the firmware or whatever?
Doh, I missed that. Yes, I think we need to do that.
> Which drivers actually will end up using it and how?
Currently I'm only aware of iwl3945 and iwlagn. I have some example
patches for them, but they aren't ready yet.
--
Kalle Valo
next prev parent reply other threads:[~2008-11-29 7:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 19:49 [RFC v3] mac80211 dynamic power save Kalle Valo
2008-11-28 19:49 ` [RFC v3 1/4] mac80211: enable IEEE80211_CONF_PS only when associated Kalle Valo
2008-11-28 22:11 ` Johannes Berg
2008-11-29 6:50 ` Kalle Valo
2008-11-28 19:49 ` [RFC v3 2/4] mac80211: implement dynamic power save Kalle Valo
2008-11-28 22:14 ` Johannes Berg
2008-11-29 6:53 ` Kalle Valo
2008-12-01 19:10 ` Luis R. Rodriguez
2008-12-01 22:40 ` Johannes Berg
2008-12-01 23:49 ` Luis R. Rodriguez
2008-12-02 19:42 ` Kalle Valo
2008-11-28 19:49 ` [RFC v3 3/4] mac80211: add IEEE80211_HW_NO_DYNAMIC_PS flag Kalle Valo
2008-11-28 22:15 ` Johannes Berg
2008-11-29 6:55 ` Kalle Valo
2008-11-28 19:49 ` [RFC v3 4/4] mac80211: move dynamic_ps_timeout to hw.conf Kalle Valo
2008-11-28 22:18 ` Johannes Berg
2008-11-29 7:00 ` Kalle Valo [this message]
2008-12-01 19:11 ` Luis R. Rodriguez
2008-12-01 19:41 ` Johannes Berg
2008-12-01 20:36 ` Luis R. Rodriguez
2008-12-01 20:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87myfj10gc.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).