* [PATCH] wifi:rt2x00: don't overwrite SoC specific bbp init
@ 2024-02-26 6:40 serge
2024-02-26 7:18 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: serge @ 2024-02-26 6:40 UTC (permalink / raw)
To: linux-wireless; +Cc: Stanislaw Gruszka
SoCs rt305x have the same MAC version but SoC specific bbp init function
Signed-off-by: Serge Vailugin <vasilugin@yandex.ru>
---
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -7257,7 +7257,8 @@ static void rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
case RT2860:
case RT2872:
case RT2883:
- rt2800_init_bbp_28xx(rt2x00dev);
+ if (!rt2800_is_305x_soc(rt2x00dev))
+ rt2800_init_bbp_28xx(rt2x00dev);
break;
case RT3070:
case RT3071:
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi:rt2x00: don't overwrite SoC specific bbp init
2024-02-26 6:40 [PATCH] wifi:rt2x00: don't overwrite SoC specific bbp init serge
@ 2024-02-26 7:18 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2024-02-26 7:18 UTC (permalink / raw)
To: serge; +Cc: linux-wireless, Stanislaw Gruszka
"serge" <vasilugin@yandex.ru> writes:
> SoCs rt305x have the same MAC version but SoC specific bbp init function
>
> Signed-off-by: Serge Vailugin <vasilugin@yandex.ru>
The commit message should answer to the question 'Why?'. What user
visible issue/symptom does this patch fix?
Also From field need to match with s-o-b, now the names are different.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-26 6:40 [PATCH] wifi:rt2x00: don't overwrite SoC specific bbp init serge
2024-02-26 7:18 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).