linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net v2] wifi: ath9k: Remove error checking for debugfs_create_dir()
@ 2023-07-14  8:49 Wang Ming
  2023-07-20  6:57 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Ming @ 2023-07-14  8:49 UTC (permalink / raw)
  To: Toke Høiland-Jørgensen, Kalle Valo, linux-wireless,
	linux-kernel
  Cc: opensource.kernel, quic_jjohnson, Wang Ming

It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in ath9k_htc_init_debug().

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/wireless/ath/ath9k/htc_drv_debug.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
index b3ed65e5c4da..85ad45771b44 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
@@ -491,8 +491,6 @@ int ath9k_htc_init_debug(struct ath_hw *ah)
 
 	priv->debug.debugfs_phy = debugfs_create_dir(KBUILD_MODNAME,
 					     priv->hw->wiphy->debugfsdir);
-	if (!priv->debug.debugfs_phy)
-		return -ENOMEM;
 
 	ath9k_cmn_spectral_init_debug(&priv->spec_priv, priv->debug.debugfs_phy);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net v2] wifi: ath9k: Remove error checking for debugfs_create_dir()
  2023-07-14  8:49 [PATCH net v2] wifi: ath9k: Remove error checking for debugfs_create_dir() Wang Ming
@ 2023-07-20  6:57 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-07-20  6:57 UTC (permalink / raw)
  To: Wang Ming
  Cc: Toke Høiland-Jørgensen, linux-wireless, linux-kernel,
	opensource.kernel, quic_jjohnson

Wang Ming <machel@vivo.com> writes:

> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in ath9k_htc_init_debug().
>
> Signed-off-by: Wang Ming <machel@vivo.com>

This is not urgent and should go to ath-next, not to the net tree.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-20  6:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-14  8:49 [PATCH net v2] wifi: ath9k: Remove error checking for debugfs_create_dir() Wang Ming
2023-07-20  6:57 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).