From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B96E8C4167D for ; Wed, 23 Nov 2022 15:21:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238401AbiKWPVv (ORCPT ); Wed, 23 Nov 2022 10:21:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238772AbiKWPVc (ORCPT ); Wed, 23 Nov 2022 10:21:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A98C920AB; Wed, 23 Nov 2022 07:21:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 84969B820DD; Wed, 23 Nov 2022 15:21:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6CACC433C1; Wed, 23 Nov 2022 15:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669216867; bh=XQZ/g+Sw4U+xIS3JiKRjNmg5QYe4GG7CLFMNcWE+7dg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Xp+Pc2frUVEZdshdbKf7x6iMGbOpkBFfpY28RhPayp1ot+dsTqVpETaB/8g7/9X0M 1iSwoJBLwa8h/vIhH2Zb9YfpoeNF1QjyT8xs6fdfPeH2s2LxcGl8CUuiO9li8x7ce2 FcA/1M+uHvUp820PhCldzR4cOjtaRks1R+EW6aRscTIajm9EBwDFTK71YvBescokKt +9WYLWtiTlBCsXUfWq/sNqf4dKjr0LyB8yVaqeZ2gND1Dh4pwJes9qIct1t0a8VRX1 66bMDwWlnBBlVKorhQyIdHUTPy0sowjK1lQXKve+7+KXqmY1hJ8Q1e8Awz1x53w0Sd iJljBQ6lqT2jg== From: Kalle Valo To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Oleksij Rempel , Maciej =?utf-8?Q?=C5=BBenczykowski?= , Neil Armstrong , Mauro Carvalho Chehab , Andrzej Pietrasiewicz , Jacopo Mondi , =?utf-8?Q?=C5=81ukasz?= Stelmach , Laurent Pinchart , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Ilja Van Sprundel , Joseph Tartaro Subject: Re: [PATCH] USB: disable all RNDIS protocol drivers References: <20221123124620.1387499-1-gregkh@linuxfoundation.org> Date: Wed, 23 Nov 2022 17:21:01 +0200 In-Reply-To: <20221123124620.1387499-1-gregkh@linuxfoundation.org> (Greg Kroah-Hartman's message of "Wed, 23 Nov 2022 13:46:20 +0100") Message-ID: <87o7sxofxe.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Greg Kroah-Hartman writes: > The Microsoft RNDIS protocol is, as designed, insecure and vulnerable on > any system that uses it with untrusted hosts or devices. Because the > protocol is impossible to make secure, just disable all rndis drivers to > prevent anyone from using them again. > > Windows only needed this for XP and newer systems, Windows systems older > than that can use the normal USB class protocols instead, which do not > have these problems. > > Android has had this disabled for many years so there should not be any > real systems that still need this. > > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Kalle Valo > Cc: Oleksij Rempel > Cc: "Maciej =C5=BBenczykowski" > Cc: Neil Armstrong > Cc: Mauro Carvalho Chehab > Cc: Andrzej Pietrasiewicz > Cc: Jacopo Mondi > Cc: "=C5=81ukasz Stelmach" > Cc: Laurent Pinchart > Cc: linux-usb@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-wireless@vger.kernel.org > Reported-by: Ilja Van Sprundel > Reported-by: Joseph Tartaro > Signed-off-by: Greg Kroah-Hartman > --- > Note, I'll submit patches removing the individual drivers for later, but > that is more complex as unwinding the interaction between the CDC > networking and RNDIS drivers is tricky. For now, let's just disable all > of this code as it is not secure. > > I can take this through the USB tree if the networking maintainers have > no objection. I thought I had done this months ago, when the last round > of "there are bugs in the protocol!" reports happened at the end of > 2021, but forgot to do so, my fault. > > drivers/net/usb/Kconfig | 1 + > drivers/net/wireless/Kconfig | 1 + For wireless: Acked-by: Kalle Valo Feel free to take this via your tree. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes