From: Kalle Valo <kvalo@codeaurora.org>
To: Isaac Hermida <isaac.hermida@digi.com>
Cc: <ath10k@lists.infradead.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH][master/pending] ath10k: assign new interfaces type to parent type
Date: Mon, 21 Dec 2020 20:25:44 +0200 [thread overview]
Message-ID: <87o8innhhz.fsf@codeaurora.org> (raw)
In-Reply-To: <20190712100846.11158-1-isaac.hermida@digi.com> (Isaac Hermida's message of "Fri, 12 Jul 2019 12:08:46 +0200")
Isaac Hermida <isaac.hermida@digi.com> writes:
> This is needed to have the AP mode working for SDIO.
> Tested with lastest master/pending code on a QCA6564 chip with firmware
> firmware-sdio-6.bin_WLAN.RMH.4.4.1-00011-QCARMSWP-2
>
> Signed-off-by: Isaac Hermida <isaac.hermida@digi.com>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index e43a566eef77..2c4f8da98b24 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -5150,6 +5150,9 @@ static int ath10k_add_interface(struct ieee80211_hw *hw,
> arvif->ar = ar;
> arvif->vif = vif;
>
> + // assign type of the new interface to the parent type (SDIO, PCI, etc)
> + ar->dev_type = arvif->ar->bus_param.dev_type;
ar->dev_type is unused in ath10k, I don't understand how this patch
could change any functionality.
But I submitted a patch to remove ar->dev_type:
https://lore.kernel.org/ath10k/1608574994-30706-1-git-send-email-kvalo@codeaurora.org/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-12-21 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 10:08 [PATCH][master/pending] ath10k: assign new interfaces type to parent type Isaac Hermida
2020-12-21 18:25 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8innhhz.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=isaac.hermida@digi.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).