From: Kalle Valo <kvalo@codeaurora.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
"David Miller" <davem@davemloft.net>,
"Mike Marciniszyn" <mike.marciniszyn@cornelisnetworks.com>,
"Dennis Dalessandro" <dennis.dalessandro@cornelisnetworks.com>,
"Doug Ledford" <dledford@redhat.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>, "Bjørn Mork" <bjorn@mork.no>,
"Igor Mitsyanko" <imitsyanko@quantenna.com>,
"Sergey Matyukevich" <geomatsi@gmail.com>,
"Oliver Neukum" <oneukum@suse.com>,
"Peter Korsgaard" <jacmet@sunsite.dk>,
"Steve Glendinning" <steve.glendinning@shawell.net>,
"Microchip Linux Driver Support" <UNGLinuxDriver@microchip.com>,
"Jussi Kivilinna" <jussi.kivilinna@iki.fi>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-rdma@vger.kernel.org,
"Linux USB Mailing List" <linux-usb@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH net-next 3/5] qtnfmac: switch to core handling of rx/tx byte/packet counters
Date: Wed, 11 Nov 2020 19:12:22 +0200 [thread overview]
Message-ID: <87o8k34y2x.fsf@codeaurora.org> (raw)
In-Reply-To: <4b22c155-6868-793f-ebfe-f797e16b9c40@gmail.com> (Heiner Kallweit's message of "Tue, 10 Nov 2020 20:48:54 +0100")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> Use netdev->tstats instead of a member of qtnf_vif for storing a pointer
> to the per-cpu counters. This allows us to use core functionality for
> statistics handling.
> The driver sets netdev->needs_free_netdev, therefore freeing the per-cpu
> counters at the right point in time is a little bit tricky. Best option
> seems to be to use the ndo_init/ndo_uninit callbacks.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/wireless/quantenna/qtnfmac/core.c | 78 ++++---------------
> drivers/net/wireless/quantenna/qtnfmac/core.h | 4 -
> .../quantenna/qtnfmac/pcie/pearl_pcie.c | 4 +-
> .../quantenna/qtnfmac/pcie/topaz_pcie.c | 4 +-
> 4 files changed, 20 insertions(+), 70 deletions(-)
Jakub, feel free to take this to net-next:
Acked-by: Kalle Valo <kvalo@codeaurora.org>
But I can also take this to wireless-drivers-next, whichever you prefer.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-11 17:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 19:46 [PATCH net-next 0/5] net: switch further drivers to core functionality for handling per-cpu byte/packet counters Heiner Kallweit
2020-11-10 19:47 ` [PATCH net-next 1/5] IB/hfi1: switch to core handling of rx/tx " Heiner Kallweit
2020-11-11 17:03 ` Jakub Kicinski
2020-11-12 13:49 ` Jason Gunthorpe
2020-11-12 21:24 ` Heiner Kallweit
2020-11-10 19:48 ` [PATCH net-next 2/5] qmi_wwan: " Heiner Kallweit
2020-11-11 12:11 ` Bjørn Mork
2020-11-10 19:48 ` [PATCH net-next 3/5] qtnfmac: " Heiner Kallweit
2020-11-11 17:12 ` Kalle Valo [this message]
2020-11-10 19:50 ` [PATCH net-next 4/5] usbnet: " Heiner Kallweit
2020-11-10 19:51 ` [PATCH net-next 5/5] net: usb: switch to dev_get_tstats64 and remove usbnet_get_stats64 alias Heiner Kallweit
2020-11-11 12:13 ` Bjørn Mork
2020-11-12 23:04 ` [PATCH net-next 0/5] net: switch further drivers to core functionality for handling per-cpu byte/packet counters Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8k34y2x.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=geomatsi@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=imitsyanko@quantenna.com \
--cc=jacmet@sunsite.dk \
--cc=jgg@ziepe.ca \
--cc=jussi.kivilinna@iki.fi \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).