From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F84FC2D0DB for ; Sun, 26 Jan 2020 15:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01A0D2071E for ; Sun, 26 Jan 2020 15:04:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="KUZfxRUp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbgAZPEM (ORCPT ); Sun, 26 Jan 2020 10:04:12 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:16798 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbgAZPEL (ORCPT ); Sun, 26 Jan 2020 10:04:11 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1580051050; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=lEA3nAQXudBZXMS+YI5pGVMcTwNkAB7aV/LxO5z8UZs=; b=KUZfxRUpghidsRwl+lIWfx/pyJhljoRcaLgQ40qyQxEJWb9Rb7OUm1jkHG/SpducAVjFWPHp m68ofgZagG/3jHYwE5FvSC5Pu1O9R6wHd34zuM6Hnim8UogwC0+R031ybLNf7hg6tL3Rf/ru 57msjvtOHkVq/EGsEADI2NnFF78= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e2daa69.7fc68798a5a8-smtp-out-n01; Sun, 26 Jan 2020 15:04:09 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AD55CC4479F; Sun, 26 Jan 2020 15:04:08 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5C2DFC43383; Sun, 26 Jan 2020 15:04:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5C2DFC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Kalle Valo Cc: Antti Antinoja , linux-wireless@vger.kernel.org, , , , Subject: Re: mwifiex: exit on error - without calling rcu_read_unlock() References: <20200126211844.0dd4a761@gail> <87sgk2xq0v.fsf@tynnyri.adurom.net> Date: Sun, 26 Jan 2020 17:04:04 +0200 In-Reply-To: <87sgk2xq0v.fsf@tynnyri.adurom.net> (Kalle Valo's message of "Sun, 26 Jan 2020 16:15:28 +0200") Message-ID: <87o8uqxnrv.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > Antti Antinoja writes: > >> Please refer to: >> >> * https://grsecurity.net/the_life_of_a_bad_security_fix >> * >> https://github.com/torvalds/linux/commit/3d94a4a8373bf5f45cf5f939e88b8354dbf2311b#diff-c5e2f17b92b8e8f30306c5dd148d874f >> >> At quick glance it looks to me like the issue really is there: Not >> calling rcu_read_unlock() before return on line 237. > > Ganapahti, can you send a fix this for this? > > Remember to add to the commit log: > > Fixes: 3d94a4a8373b ("mwifiex: fix possible heap overflow in mwifiex_process_country_ie()") Oh, there was already a fix available: https://patchwork.kernel.org/patch/11320227/ It just got piled up with all the patches. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches