From: Kalle Valo <kvalo@codeaurora.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
"Tomislav Požega" <pozega.tomislav@gmail.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Felix Fietkau" <nbd@nbd.name>, "Mathias Kresin" <dev@kresin.me>
Subject: Re: [RFC/RFT 7/7] rt2800: do not enable watchdog by default
Date: Tue, 30 Apr 2019 16:25:29 +0300 [thread overview]
Message-ID: <87o94nwrp2.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1556535270-3551-8-git-send-email-sgruszka@redhat.com> (Stanislaw Gruszka's message of "Mon, 29 Apr 2019 12:54:30 +0200")
Stanislaw Gruszka <sgruszka@redhat.com> writes:
> Make watchdog disabled by default and add module parameter to enable it.
>
> User will have to create file in /etc/modprobe.d/ with
>
> options rt2800lib watchdog=1
>
> to enable the watchdog or load "rt2800lib watchdog=1" module manually
> before loading rt2800{soc,pci,usb} module.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
[...]
> +static bool modparam_watchdog;
> +module_param_named(watchdog, modparam_watchdog, bool, S_IRUGO);
> +MODULE_PARM_DESC(watchdog, "Enable watchdog.");
You could describe a bit more what this watchdog does and that it's in
driver (or at least I assume so).
--
Kalle Valo
prev parent reply other threads:[~2019-04-30 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 10:54 [RFC/RFT 0/7] rt2800: add experimental watchdog implementation Stanislaw Gruszka
2019-04-29 10:54 ` [RFC/RFT 1/7] rt2x00: allow to specify watchdog interval Stanislaw Gruszka
2019-04-29 10:54 ` [RFC/RFT 2/7] rt2800: add helpers for reading dma done index Stanislaw Gruszka
2019-04-29 10:54 ` [RFC/RFT 3/7] rt2800: initial watchdog implementation Stanislaw Gruszka
2019-04-29 10:54 ` [RFC/RFT 4/7] rt2800: add pre_reset_hw callback Stanislaw Gruszka
2019-04-29 10:54 ` [RFC/RFT 5/7] rt2800: do not nullify initialization vector data Stanislaw Gruszka
2019-04-29 10:54 ` [RFC/RFT 6/7] rt2x00: add restart hw Stanislaw Gruszka
2019-04-29 10:54 ` [RFC/RFT 7/7] rt2800: do not enable watchdog by default Stanislaw Gruszka
2019-04-30 13:25 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o94nwrp2.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pozega.tomislav@gmail.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox