From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Johannes Berg <johannes.berg@intel.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH] wireless: airo: potential buffer overflow in sprintf()
Date: Wed, 24 Oct 2018 12:23:51 +0300 [thread overview]
Message-ID: <87o9bjsno8.fsf@codeaurora.org> (raw)
In-Reply-To: <20181024090721.uxgwo6h6p3h6u5vp@mwanda> (Dan Carpenter's message of "Wed, 24 Oct 2018 12:07:21 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Wed, Oct 24, 2018 at 11:56:53AM +0300, Kalle Valo wrote:
>> Dan Carpenter <dan.carpenter@oracle.com> writes:
>>
>> > It looks like we wanted to print a maximum of BSSList_rid.ssidLen bytes
>> > of the ssid, but we accidentally use "%*s" (width) instead of "%.*s"
>> > (precision) so if the ssid doesn't have a NUL terminator this could lead
>> > to an overflow.
>> >
>> > Fixes: e174961ca1a0 ("net: convert print_mac to %pM")
>> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> > ---
>> > Static analsysis. Not tested.
>>
>> IMHO this part (after "---" line) is important information and should be
>> part of commit log. I can fix that.
>>
>
> In my experience most maintainers disagree (with varying degrees of
> intensity).
Heh, why would adding four words explaining the background of the patch
to a commit log would be a bad thing? :) Well, I guess I just view
things differently.
--
Kalle Valo
next prev parent reply other threads:[~2018-10-24 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 8:33 [PATCH] wireless: airo: potential buffer overflow in sprintf() Dan Carpenter
2018-10-24 8:56 ` Kalle Valo
2018-10-24 9:07 ` Dan Carpenter
2018-10-24 9:23 ` Kalle Valo [this message]
2018-10-24 9:26 ` Amir Goldstein
2018-11-06 17:03 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9bjsno8.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amir73il@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox