From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Manikanta Pubbisetty <mpubbise@codeaurora.org>,
johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
Manikanta Pubbisetty <mpubbise@codeaurora.org>
Subject: Re: [PATCHv2] mac80211: add stop/start logic for software TXQs
Date: Tue, 10 Jul 2018 14:58:18 +0200 [thread overview]
Message-ID: <87o9ffcknp.fsf@toke.dk> (raw)
In-Reply-To: <1531225597-4736-1-git-send-email-mpubbise@codeaurora.org>
> diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> index 172aeae..d07f7f9 100644
> --- a/net/mac80211/ieee80211_i.h
> +++ b/net/mac80211/ieee80211_i.h
> @@ -818,6 +818,7 @@ enum txq_info_flags {
> IEEE80211_TXQ_STOP,
> IEEE80211_TXQ_AMPDU,
> IEEE80211_TXQ_NO_AMSDU,
> + IEEE80211_TXQ_PAUSED,
> };
I think it would be a good idea to either rename the flags, or at least
add an explanation somewhere of the difference between a paused and a
stopped queue...
> /**
> @@ -1226,6 +1227,7 @@ struct ieee80211_local {
>
> struct sk_buff_head pending[IEEE80211_MAX_QUEUES];
> struct tasklet_struct tx_pending_tasklet;
> + struct tasklet_struct wake_txqs_tasklet;
It's not quite clear to me why a tasklet is needed? Couldn't you just
call the ieee80211_wake_txqs() function at the same place where you
currently schedule the tasklet?
-Toke
next prev parent reply other threads:[~2018-07-10 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 12:26 [PATCHv2] mac80211: add stop/start logic for software TXQs Manikanta Pubbisetty
2018-07-10 12:58 ` Toke Høiland-Jørgensen [this message]
2018-07-10 15:04 ` Manikanta Pubbisetty
2018-07-10 15:22 ` Toke Høiland-Jørgensen
2018-07-10 16:27 ` Manikanta Pubbisetty
2018-07-10 17:39 ` Toke Høiland-Jørgensen
2018-07-10 16:03 ` kbuild test robot
2018-07-10 16:12 ` Manikanta Pubbisetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9ffcknp.fsf@toke.dk \
--to=toke@toke.dk \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mpubbise@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).