From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Govind Singh <govinds@codeaurora.org>,
devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org, bjorn.andersson@linaro.org,
david.brown@linaro.org, Rob Herring <robh+dt@kernel.org>,
andy.gross@linaro.org
Subject: Re: [PATCH v2 3/6] dt: bindings: add bindings for msa memory region
Date: Tue, 03 Jul 2018 18:42:24 +0300 [thread overview]
Message-ID: <87o9fonx5r.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180605231814.GB194157@rodete-desktop-imager.corp.google.com> (Brian Norris's message of "Tue, 5 Jun 2018 16:18:16 -0700")
Brian Norris <briannorris@chromium.org> writes:
> + Rob
>
> On Tue, Jun 05, 2018 at 06:06:16PM +0530, Govind Singh wrote:
>> Add device tree binding documentation details of msa
>> memory region for ath10k qmi client for SDM845/APQ8098
>> SoC into "qcom,ath10k.txt".
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>> ---
>> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> index 7fd4e8ce4149..0efc47f4ba34 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> @@ -56,6 +56,8 @@ Optional properties:
>> the length can vary between hw versions.
>> - <supply-name>-supply: handle to the regulator device tree node
>> optional "supply-name" is "vdd-0.8-cx-mx".
>> +- msa-fixed-region: phandle, specifier to children of reserved MSA memory.
>
> As in reserved-memory/reserved-memory.txt? Might refer to that doc here.
> Or is this some other kind of reserved memory?
>
> If the former, it's normally called just "memory-region", although
> that does seem somewhat non-descriptive...
>
>> +- msa-size: MSA memory size for fw internal use.
>
> Do you really need both of these? It seems like your code uses one or
> the other, not both. In which case, this is not a very good description,
> because it sounds like they would go together.
>
> Also, if you're not using standard/generic properties (e.g., the
> aforementioned "memory-region" binding), you typically should use a
> vendor prefix, like "qcom,msa-size".
Devicetree folks, any comments? I would like to apply this via my
ath.git tree but need help with the review.
Full patch here:
https://patchwork.kernel.org/patch/10448169/
--
Kalle Valo
next prev parent reply other threads:[~2018-07-03 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 12:36 [PATCH v2 3/6] dt: bindings: add bindings for msa memory region Govind Singh
2018-06-05 23:18 ` Brian Norris
2018-07-03 15:42 ` Kalle Valo [this message]
2018-07-03 16:01 ` Mark Rutland
2018-07-04 9:51 ` Govind Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9fonx5r.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=briannorris@chromium.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=govinds@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).