From: Kalle Valo <kvalo@codeaurora.org>
To: Pkshih <pkshih@realtek.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"Larry.Finger\@lwfinger.net" <Larry.Finger@lwfinger.net>
Subject: Optimising maintainer's time
Date: Fri, 29 Jun 2018 11:06:33 +0300 [thread overview]
Message-ID: <87o9fuf246.fsf_-_@codeaurora.org> (raw)
In-Reply-To: <1527734181.8418.13.camel@realtek.com> (pkshih@realtek.com's message of "Thu, 31 May 2018 02:36:38 +0000")
(Was "Re: [PATCH v4 0/9] rtlwifi: btcoex: Add 8822b btcoex support" but
I'll change the title to get more visibility as this is a general advice
for everyone)
Pkshih <pkshih@realtek.com> writes:
> I would like to send v5 to change the order of this patchset like:
> =C2=A0 rtlwifi: btcoex: remove comments that are not meaningful
> =C2=A0 rtlwifi: btcoex: Add modifier const to version related variables
> =C2=A0 rtlwifi: btcoex: Add struct members to replace global varaibles
> =C2=A0 rtlwifi: btcoex: Remove global variables of chip specific context
>
> =C2=A0 rtlwifi: btcoex: Add 8822b1ant coex files
> =C2=A0 rtlwifi: btcoex: Add 8822b2ant coex files
> =C2=A0 rtlwifi: btcoex: Add 8822b header files to precomp.h
> =C2=A0 rtlwifi: btcoex: Add 8822b to Makefile
> =C2=A0 rtlwifi: btcoex: Add 8822b routine to btc interfaces
>
> Then, you can review patches 1/9 - 4/9 that refine btcoex, and the
> remaining 8822b's btcoex can review later. Does it work for you?
I have forgotten the details already so I can't really comment about
this patchset.
But what I can say is that you need to consider maintainer's time, it's
usually limited (all maintainers are busy). If my time is abused (in
networking terms) there will be bufferbloat and I need to start doing
fair queing, and nobody wants that :)
So whenever you are submitting patches consider how you can most
effectively optimise maintainer's time (size of patches, quality of
code, following the rules etc). When you do that, over time you will
notice that your patches get applied faster. But if you do the opposite,
you will notice that it takes longer and harder to get your patches in.
--=20
Kalle Valo
prev parent reply other threads:[~2018-06-29 8:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 6:16 [PATCH v4 0/9] rtlwifi: btcoex: Add 8822b btcoex support pkshih
2018-04-13 6:16 ` [PATCH v4 1/9] rtlwifi: btcoex: Add 8822b1ant coex files pkshih
2018-04-13 6:16 ` [PATCH v4 2/9] rtlwifi: btcoex: Add 8822b2ant " pkshih
2018-04-13 6:16 ` [PATCH v4 3/9] rtlwifi: btcoex: Add 8822b header files to precomp.h pkshih
2018-04-13 6:16 ` [PATCH v4 4/9] rtlwifi: btcoex: Add 8822b to Makefile pkshih
2018-04-13 6:16 ` [PATCH v4 5/9] rtlwifi: btcoex: Add 8822b routine to btc interfaces pkshih
2018-04-13 6:16 ` [PATCH v4 6/9] rtlwifi: btcoex: remove comments that are not meaningful pkshih
2018-04-13 6:16 ` [PATCH v4 7/9] rtlwifi: btcoex: Add modifier const to version related variables pkshih
2018-04-13 6:16 ` [PATCH v4 8/9] rtlwifi: btcoex: Add struct members to replace global varaibles pkshih
2018-04-13 6:16 ` [PATCH v4 9/9] rtlwifi: btcoex: Remove global variables of chip specific context pkshih
2018-05-31 2:36 ` [PATCH v4 0/9] rtlwifi: btcoex: Add 8822b btcoex support Pkshih
2018-06-29 8:06 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9fuf246.fsf_-_@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).