From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: fix firmware request processing if nvram load fails
Date: Tue, 03 Apr 2018 13:04:58 +0300 [thread overview]
Message-ID: <87o9j0ip11.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1522743495-13004-1-git-send-email-arend.vanspriel@broadcom.com> (Arend van Spriel's message of "Tue, 3 Apr 2018 10:18:15 +0200")
Arend van Spriel <arend.vanspriel@broadcom.com> writes:
> When nvram loading fails a double free occurred. Fix this and reorg the
> code a little.
>
> Fixes: commit d09ae51a4b67 ("brcmfmac: pass struct in brcmf_fw_get_firmwares()")
This should be:
Fixes: d09ae51a4b67 ("brcmfmac: pass struct in brcmf_fw_get_firmwares()")
I can fix that during commit.
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> ---
> Hi Kalle,
>
> This fix is for code currently(?) in linux-next in error path caused
> a double free.
Ok, I'll queue this to wireless-drivers (after I have fast forwarded it)
for 4.17.
--
Kalle Valo
next prev parent reply other threads:[~2018-04-03 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 8:18 [PATCH] brcmfmac: fix firmware request processing if nvram load fails Arend van Spriel
2018-04-03 10:04 ` Kalle Valo [this message]
2018-04-03 11:16 ` Arend van Spriel
2018-04-09 15:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9j0ip11.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).