From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:42852 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbeCNJFi (ORCPT ); Wed, 14 Mar 2018 05:05:38 -0400 From: Kalle Valo To: tcharding Cc: kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Tycho Andersen , Kees Cook Subject: Re: [RESEND] rsi: Remove stack VLA usage References: <1520819022-15238-1-git-send-email-me@tobin.cc> <20180312094606.8192B6081A@smtp.codeaurora.org> <20180313201757.GK8631@eros> Date: Wed, 14 Mar 2018 11:05:32 +0200 In-Reply-To: <20180313201757.GK8631@eros> (tcharding's message of "Wed, 14 Mar 2018 07:17:57 +1100") Message-ID: <87o9jr6n8j.fsf@codeaurora.org> (sfid-20180314_100556_719541_80E68852) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: tcharding writes: > On Mon, Mar 12, 2018 at 09:46:06AM +0000, Kalle Valo wrote: >> tcharding wrote: >> >> > The kernel would like to have all stack VLA usage removed[1]. rsi uses >> > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size >> > is defined using a magic number. We can use a pre-processor defined >> > constant and declare the array to maximum size. We add a check before >> > accessing the array in case of programmer error. >> > >> > [1]: https://lkml.org/lkml/2018/3/7/621 >> > >> > Signed-off-by: Tobin C. Harding >> >> Tobin, your name in patchwork.kernel.org is just "tcharding" then it should be >> "Tobin C. Harding". Patchwork is braindead in a way as it takes the name from >> it's database instead of the From header of the patch in question. >> >> I can fix that manually but it would be helpful if you could register to >> patchwork and fix your name during registration. You have only one chance to >> fix your name (another braindead feature!) so be careful :) > > Hi Kalle, > > I logged into my patchwork account but I don't see any way to set the > name. Within 'profile' there is only 'change password' and 'link > email'. I thought I could unregister then re-register but I can't see > how to do that either. Ok, maybe you have registered (=logged on for the first time) already earlier so it's not possible to change the name anymore. > Is there a maintainer of patchwork.kernel.org who I can email to > manually remove me from the system? helpdesk@kernel.org should be able to fix your name in patchwork, at least they have done it in the past. This is not the first time this has happened. -- Kalle Valo