From: Kalle Valo <kvalo@codeaurora.org>
To: Jes Sorensen <jes.sorensen@gmail.com>
Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs
Date: Wed, 11 Oct 2017 11:41:49 +0300 [thread overview]
Message-ID: <87o9peqdo2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <5f5f0f54-d901-90be-9025-0a1c4b909368@gmail.com> (Jes Sorensen's message of "Tue, 10 Oct 2017 15:35:10 -0400")
Jes Sorensen <jes.sorensen@gmail.com> writes:
> On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
> While this isn't harmful, to me this looks like pointless patch churn
> for zero gain and it's just ugly.
In general I find it useful to mark fall through cases. And it's just a
comment with two words, so they cannot hurt your eyes that much.
--
Kalle Valo
next prev parent reply other threads:[~2017-10-11 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 19:30 [PATCH] rtl8xxxu: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-10 19:35 ` Jes Sorensen
2017-10-10 19:55 ` Florian Fainelli
2017-10-11 8:41 ` Kalle Valo [this message]
2017-10-11 13:34 ` Jes Sorensen
2017-10-11 14:32 ` Gustavo A. R. Silva
2017-10-11 17:00 ` Kees Cook
2017-10-12 4:32 ` Kalle Valo
2017-10-11 10:20 ` Joe Perches
2017-10-11 12:54 ` David Laight
2017-10-11 17:47 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9peqdo2.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=garsilva@embeddedor.com \
--cc=jes.sorensen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).