From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35926 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbdDMNNt (ORCPT ); Thu, 13 Apr 2017 09:13:49 -0400 From: Kalle Valo To: Brian Norris Cc: Nishant Sarmukadam , Ganapathi Bhat , Xinming Hu , linux-kernel@vger.kernel.org, Dmitry Torokhov , netdev@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH] mwifiex: MAC randomization should not be persistent References: <20170405222640.4494-1-briannorris@chromium.org> <87inmifak8.fsf@kamboji.qca.qualcomm.com> <20170406164807.GB25323@google.com> Date: Thu, 13 Apr 2017 16:13:40 +0300 In-Reply-To: <20170406164807.GB25323@google.com> (Brian Norris's message of "Thu, 6 Apr 2017 09:48:08 -0700") Message-ID: <87o9w0bgcb.fsf@kamboji.qca.qualcomm.com> (sfid-20170413_151405_182890_5DBA6885) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Brian Norris writes: > On Thu, Apr 06, 2017 at 07:02:15AM +0300, Kalle Valo wrote: >> Brian Norris writes: >> >> > nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan >> > request that should be randomized; the absence of such a flag means we >> > should not randomize. However, mwifiex was stashing the latest >> > randomization request and *always* using it for future scans, even those >> > that didn't set the flag. >> > >> > Let's zero out the randomization info whenever we get a scan request >> > without NL80211_SCAN_FLAG_RANDOM_ADDR. I'd prefer to remove >> > priv->random_mac entirely (and plumb the randomization MAC properly >> > through the call sequence), but the spaghetti is a little difficult to >> > unravel here for me. >> > >> > Fixes: c2a8f0ff9c6c ("mwifiex: support random MAC address for scanning") >> >> So the first release with this was v4.9. >> >> > Signed-off-by: Brian Norris >> > --- >> > Should this be tagged for -stable? >> >> IMHO yes. > > Sounds fine to me. I suppose you'll do this when applying? Or I can > resend... I can add this: Cc: # 4.9+ -- Kalle Valo