From: Kalle Valo <kvalo@codeaurora.org>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Greg KH <greg@kroah.com>,
linux-wireless@vger.kernel.org, Larry.Finger@lwfinger.net,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue
Date: Mon, 03 Oct 2016 10:29:49 +0300 [thread overview]
Message-ID: <87oa31sxea.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <wrfjshsg5k21.fsf@redhat.com> (Jes Sorensen's message of "Sat, 01 Oct 2016 08:29:42 -0400")
Jes Sorensen <Jes.Sorensen@redhat.com> writes:
> Greg KH <greg@kroah.com> writes:
>> On Fri, Sep 30, 2016 at 07:35:17PM -0400, Jes.Sorensen@redhat.com wrote:
>>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>>
>>> The generic disable_rf() function clears bits 22 and 23 in
>>> REG_RX_WAIT_CCA, however we did not re-enable them again in
>>> rtl8723b_enable_rf()
>>>
>>> This resolves the problem for me with 8723bu devices not working again
>>> after reloading the driver.
>>>
>>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>>> ---
>>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>
>> <formletter>
>>
>> This is not the correct way to submit patches for inclusion in the
>> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
>> for how to do this properly.
>>
>> </formletter>
>
> DOH Kalle told me to CC stable I took it for granted that you meant CC
> in the email sense. Guess I get to blame my self for looking like a
> fool in public.
Yes, I meant adding it to the commit log. This part of the stable
process is a bit confusing, I should have been more clear how this
works.
> I'll send you an email directly with the SHA once it hits Linus' tree
> instead.
No need, I'll add this to the commit log and the stable team will get
the commit automatically once the commit is in Linus' tree:
Cc: stable@vger.kernel.org # 4.7+
--
Kalle Valo
next prev parent reply other threads:[~2016-10-03 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 23:35 [PATCH 0/2] rtl8xxxu: Fix driver reload issues with 8723bu and 8192eu Jes.Sorensen
2016-09-30 23:35 ` [PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue Jes.Sorensen
2016-10-01 11:56 ` Greg KH
2016-10-01 12:29 ` Jes Sorensen
2016-10-03 7:29 ` Kalle Valo [this message]
2016-10-07 11:24 ` [1/2] " Kalle Valo
2016-09-30 23:35 ` [PATCH 2/2] rtl8xxxu: Fix rtl8192eu " Jes.Sorensen
2016-10-03 7:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa31sxea.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).