From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:25453 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759505AbcIOOCx (ORCPT ); Thu, 15 Sep 2016 10:02:53 -0400 From: "Valo, Kalle" To: Ben Greear CC: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [PATCH v2 08/21] ath10k: make firmware text debug messages more verbose. Date: Thu, 15 Sep 2016 14:02:47 +0000 Message-ID: <87oa3pb6rd.fsf@kamboji.qca.qualcomm.com> (sfid-20160915_160313_517171_E3923F8A) References: <1462986153-16318-1-git-send-email-greearb@candelatech.com> <1462986153-16318-9-git-send-email-greearb@candelatech.com> <87sht2efiu.fsf@kamboji.qca.qualcomm.com> <57D9677E.5030704@candelatech.com> In-Reply-To: <57D9677E.5030704@candelatech.com> (Ben Greear's message of "Wed, 14 Sep 2016 08:06:38 -0700") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Ben Greear writes: > On 09/14/2016 07:12 AM, Valo, Kalle wrote: >> greearb@candelatech.com writes: >> >>> From: Ben Greear >>> >>> There are not many of these messages producted by the >>> firmware, but they are generally fairly useful, so print >>> them at info level. >>> >>> Signed-off-by: Ben Greear >>> --- >>> drivers/net/wireless/ath/ath10k/wmi.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wirele= ss/ath/ath10k/wmi.c >>> index 1758b4a..d9e4b77 100644 >>> --- a/drivers/net/wireless/ath/ath10k/wmi.c >>> +++ b/drivers/net/wireless/ath/ath10k/wmi.c >>> @@ -4050,7 +4050,7 @@ void ath10k_wmi_event_debug_print(struct ath10k *= ar, struct sk_buff *skb) >>> /* the last byte is always reserved for the null character */ >>> buf[i] =3D '\0'; >>> >>> - ath10k_dbg(ar, ATH10K_DBG_WMI_PRINT, "wmi print '%s'\n", buf); >>> + ath10k_info(ar, "wmi print '%s'\n", buf); >> >> Useful to whom and how? I understand that for firmware developers this >> is very valuable information and that's why we have a special debug >> level for it. But I suspect that for normal users these are just >> confusing and unnecessarily spam the log. > > CT firmare will print out some memory usage info on firmware boot, and th= at can > allow a discerning individual to tune their vdev, peer, rate-ctrl, and ot= her > object usage in order to make best use of resources in the firmware. > > These few lines can greatly aid debugging certain types of crashes and pe= rformance > loss in the firmware, so having them readily available in 'dmesg' or simi= lar > for bug reports from the field helps me. > > Stock firmware will also print out some resource usage info. It is just > a few lines on firmware boot, but it is quite useful in my experience. I'm sure it's useful for you, but we have quite a few firmware versions to support. We do not know what kind of messages they print. --=20 Kalle Valo=