Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Roman Yeryomin <leroi.lists@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"michal.kazior@tieto.com" <michal.kazior@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC/RFT] ath10k: disable wake_tx_queue for older devices
Date: Wed, 29 Jun 2016 08:58:11 +0000	[thread overview]
Message-ID: <87oa6k8j8d.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CACiydbLvke0UxJbg2sn0q-=FwXpmX+FKUV7wwEMT=qUYekJrJA@mail.gmail.com>	(Roman Yeryomin's message of "Wed, 8 Jun 2016 14:39:03 +0300")

Roman Yeryomin <leroi.lists@gmail.com> writes:

> On 2 June 2016 at 16:14, Valo, Kalle <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> Some setups suffer performance regressions with
>>> current wake_tx_queue implementation.
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>>> ---
>>> Hi Roman,
>>>
>>> Can you give this patch a try and see if it helps
>>> with your performance problems, please?
>>
>> Did anyone seeing the performance regression manage to test this? It
>> would be good to get feedback, good or bad, before I push this to 4.7.
>>
>> Full patch here:
>>
>> https://patchwork.kernel.org/patch/9111981/
>
> Sorry, didn't try yet, bad timing for me :(
> Will try to test by the end of the week

Roman, did you have a chance to test this?

Michal, could you submit this patch as a formal patch, please? I think
we should take it even if Roman hasn't tested it.

-- 
Kalle Valo

  reply	other threads:[~2016-06-29  8:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 12:47 [RFC/RFT] ath10k: disable wake_tx_queue for older devices Michal Kazior
2016-06-02 13:14 ` Valo, Kalle
2016-06-08 11:39   ` Roman Yeryomin
2016-06-29  8:58     ` Valo, Kalle [this message]
2016-06-29 11:52 ` [PATCH] " Michal Kazior
2016-07-07 16:30   ` Valo, Kalle
2016-07-31 23:35     ` Roman Yeryomin
2016-08-01  9:04       ` Dave Taht
2016-08-04 10:07         ` Roman Yeryomin
2016-08-04 12:02           ` Dave Taht
2016-07-19 13:19   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa6k8j8d.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=leroi.lists@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox