From: Kalle Valo <kvalo@codeaurora.org>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath9k_htc: introduce support for different fw versions
Date: Sun, 12 Jul 2015 15:17:41 +0300 [thread overview]
Message-ID: <87oajhvaca.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1434394689-18781-1-git-send-email-linux@rempel-privat.de> (Oleksij Rempel's message of "Mon, 15 Jun 2015 20:58:09 +0200")
Oleksij Rempel <linux@rempel-privat.de> writes:
> Current kernel support only one fw name with theoretically only one
> fw version. By replacing fw with other version we will break compatibility
> with older kernels.
>
> To avoid this kind of regression this patch will reuse fw version model
> from iwlwifi driver.
>
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
[...]
> +int htc_use_dev_fw = 0;
> +module_param_named(use_dev_fw, htc_use_dev_fw, int, 0444);
> +MODULE_PARM_DESC(use_dev_fw, "Use development FW version");
The commit log is really vague, please document properly how the
functionality changes from user point of view. And especially what does
this module parameter do? I'm a bit concerned about that.
--
Kalle Valo
next prev parent reply other threads:[~2015-07-12 12:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 16:12 [PATCH] ath9k_htc: introduce support for different fw versions Oleksij Rempel
2015-06-14 23:27 ` Julian Calaby
2015-06-15 18:55 ` Oleksij Rempel
2015-06-15 18:57 ` Oleksij Rempel
2015-06-15 18:58 ` [PATCH v2] " Oleksij Rempel
2015-07-03 4:07 ` Oleksij Rempel
2015-07-03 10:53 ` Kalle Valo
2015-07-03 17:43 ` Oleksij Rempel
2015-07-12 12:17 ` Kalle Valo [this message]
2015-07-12 17:42 ` [PATCH v3] " Oleksij Rempel
2015-08-14 5:12 ` Oleksij Rempel
2015-09-06 10:55 ` Kalle Valo
2015-09-06 11:01 ` Oleksij Rempel
2015-09-06 13:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oajhvaca.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).