Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: <ath6kl@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	<devicetree-discuss@lists.ozlabs.org>
Subject: Re: ath6kl DT support and multiple instances.
Date: Tue, 19 Aug 2014 10:38:19 +0300	[thread overview]
Message-ID: <87oavhapzo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <53F2FB31.3090802@linaro.org> (Srinivas Kandagatla's message of "Tue, 19 Aug 2014 08:22:25 +0100")

Hi Srinivas,

Srinivas Kandagatla <srinivas.kandagatla@linaro.org> writes:

> I noticed that ath6kl partially supports Device trees, via
> check_device_tree() function in init.c.

That's really old code. Sam Leffler wrote that back in 2011 and IIRC
nobody has touched it since.

> I have a use case for adding reset line and pinctrl properties to this
> dt bindings, but soon realized that this function would not work for
> multiple instances of the driver, as there is no direct
> association/binding of dt node and driver instance.
>
> Just wondering if this is a know limitation and there will be no
> possible multiple instances of this driver?
>
> is check_device_tree function obsolete?

I'm not familiar with the device tree at all so I can't really comment
much, except that I'm happy to take patches :)

> should I care about multiple instances?

Yes, I think you should.

> Other than adding static code in the board file, are there any other
> options to pass platform data like reset gpio lines and pinctrl
> properties to the driver?

Few years back we talked about adding function pointers to the board
files for that, but there never were any patches.

-- 
Kalle Valo

      reply	other threads:[~2014-08-19  7:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19  7:22 ath6kl DT support and multiple instances Srinivas Kandagatla
2014-08-19  7:38 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oavhapzo.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath6kl@lists.infradead.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox