From: Kalle Valo <kalle.valo@iki.fi>
To: reinette chatre <reinette.chatre@intel.com>
Cc: "linville\@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwl3945: fix compilation error in iwl3945_pass_packet_to_mac80211()
Date: Wed, 12 Aug 2009 21:27:13 +0300 [thread overview]
Message-ID: <87ocqkkhvi.fsf@litku.valot.fi> (raw)
In-Reply-To: <1250091440.30019.5928.camel@rc-desk> (reinette chatre's message of "Wed\, 12 Aug 2009 08\:37\:20 -0700")
reinette chatre <reinette.chatre@intel.com> writes:
> On Wed, 2009-08-12 at 04:07 -0700, Kalle Valo wrote:
>> Commit "iwlwifi: Traffic type and counter for debugFs" broke iwl3945 in
>> a case when CONFIG_IWLWIFI_LEDS is disabled:
>>
>> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: 'hdr' undeclared (first use in this function)
>>
>> Fix it by removing the ifdef check for hdr variable.
[...]
> We have an identical patch pending. I assumed most people compile with
> led support and thus did not rush to get it in.
I don't remember why I have leds disabled. Most probably some problem a
long time ago and I never bothered to turn it back on.
> Now that it is a problem for more people I think this one should go
> in.
I agree that this should go in. Compilation errors are always annoying.
--
Kalle Valo
prev parent reply other threads:[~2009-08-12 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 11:07 [PATCH] iwl3945: fix compilation error in iwl3945_pass_packet_to_mac80211() Kalle Valo
2009-08-12 15:37 ` reinette chatre
2009-08-12 18:27 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocqkkhvi.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).