From: Kalle Valo <kalle.valo@iki.fi>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Always send a null data frame if TIM bit is set.
Date: Thu, 02 Apr 2009 08:52:22 +0300 [thread overview]
Message-ID: <87ocvfiovd.fsf@litku.valot.fi> (raw)
In-Reply-To: <8e92b4100903312115l2f013083jf507b66f8449a63a@mail.gmail.com> (Vivek Natarajan's message of "Wed\, 1 Apr 2009 09\:45\:10 +0530")
Vivek Natarajan <vivek.natraj@gmail.com> writes:
> Although the above patch is a right approach, it opens up an issue
> with pspolling.
>
> In the above chunk of code, if the timeout is zero, instead of
> sending a null frame to correct the state in the AP, we may keep on
> sending ps poll frames ( And the ps state in the AP will never be
> corrected)
>
> I have not tested pspolling with ath9k. But this seems to be an issue.
> Thoughts?
Maybe it's better to have a separate test for the case that TIM bit is
set but we are not in power save and just send a nullfunc frame
without psm bit. And leave the original power save code as it was.
I really would like to have some frame ack callback to mac80211, even
not all drivers support that. Otherwise we cannot reliably go to power
save because the AP might not receive our nullfunc frame. I have to
think about this and I'll try to propose something later on.
--
Kalle Valo
next prev parent reply other threads:[~2009-04-02 5:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 14:50 [PATCH] mac80211: Always send a null data frame if TIM bit is set Vivek Natarajan
2009-03-04 10:55 ` Kalle Valo
2009-04-01 4:15 ` Vivek Natarajan
2009-04-02 5:52 ` Kalle Valo [this message]
2009-04-02 10:02 ` Johannes Berg
2009-04-02 17:30 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocvfiovd.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).