From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Alina Friedrichsen <x-alina@gmx.net>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] mac80211: Remove TSF atomic requirement from the documentation
Date: Fri, 06 Feb 2009 23:08:12 +0200 [thread overview]
Message-ID: <87ocxfp937.fsf@litku.valot.fi> (raw)
In-Reply-To: <1233953047.4175.27.camel@johannes.local> (Johannes Berg's message of "Fri\, 06 Feb 2009 21\:44\:07 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Fri, 2009-02-06 at 21:21 +0200, Kalle Valo wrote:
>> "Alina Friedrichsen" <x-alina@gmx.net> writes:
>>
>> > The atomic requirement for the TSF callbacks is outdated. get_tsf() is
>> > only called by ieee80211_rx_bss_info() which is indirectly called by
>> > the work queue ieee80211_sta_work(). In the same context are called
>> > several other non-atomic functions, too. And the atomic requirement
>> > causes problems for drivers of USB wifi cards.
>>
>> Atomicity requirement also creates problems for SPI based devices, not
>> only USB. So I strongly support for removing the requirement.
>>
>> Unfortunately I don't have time to review this, though. Sorry.
>
> It's ok, I took a look, there's no such requirement (any more).
Oh good. Thanks for checking this.
Alina, it would be nice to explicitly mention that the function can
sleep. Otherwise driver authors need to guess if sleeping is allowed
or not.
--
Kalle Valo
next prev parent reply other threads:[~2009-02-06 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 16:58 [PATCH] mac80211: Remove TSF atomic requirement from the documentation Alina Friedrichsen
2009-02-06 19:21 ` Kalle Valo
2009-02-06 20:44 ` Johannes Berg
2009-02-06 21:08 ` Kalle Valo [this message]
2009-02-06 21:11 ` Johannes Berg
2009-02-07 7:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocxfp937.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).