linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@nokia.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: Jouni Malinen <j@w1.fi>, linux-wireless@vger.kernel.org
Subject: Re: Michael MIC failures in AP mode?
Date: Sat, 01 Nov 2008 18:30:34 +0200	[thread overview]
Message-ID: <87od0zl87p.fsf@nokia.com> (raw)
In-Reply-To: <1225554697.3619.13.camel@johannes.berg> (ext Johannes Berg's message of "Sat\, 01 Nov 2008 16\:51\:37 +0100")

Johannes Berg <johannes@sipsolutions.net> writes:

> On Sat, 2008-11-01 at 17:19 +0200, Jouni Malinen wrote:
>
>> Anyway, if you just want to test Michael MIC error processing on a
>> client, force mac80211 to do software encryption
>
> On that matter, should we put a debugfs control knob in place to
> completely disable HW encryption in mac80211, so we don't need this
> override in all drivers?

I think there's a need for this and we should do it. Just look at this
commit from earlier this week:

commit 05e6eb6f607cc3623c50b2a7c62b29ba6707a316
Author: Bob Copeland <me@bobcopeland.com>
Date:   Wed Oct 29 08:30:54 2008 -0400

    ath5k: enable hardware encryption for WEP
    
    This change re-enables hardware encryption for ath5k after setting up
    mac80211 to handle the initialization vectors which happens to make it
    work.  Add a module param (nohwcrypt) to optionally turn it off.
    
    Signed-off-by: Bob Copeland <me@bobcopeland.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

Having a support in mac80211 would make it easier both for the driver
developers and users.

-- 
Kalle Valo

      parent reply	other threads:[~2008-11-01 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-01 14:31 Michael MIC failures in AP mode? Kalle Valo
2008-11-01 14:53 ` Johannes Berg
2008-11-01 15:19 ` Jouni Malinen
2008-11-01 15:45   ` Kalle Valo
2008-11-01 15:51   ` Johannes Berg
2008-11-01 16:06     ` Jouni Malinen
2008-11-01 16:06     ` Stefanik Gábor
2008-11-01 16:30     ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87od0zl87p.fsf@nokia.com \
    --to=kalle.valo@nokia.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).