From: Kalle Valo <kvalo@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Jeff Johnson" <quic_jjohnson@quicinc.com>,
"Karthikeyan Periyasamy" <quic_periyasa@quicinc.com>,
"Aloka Dixit" <quic_alokad@quicinc.com>,
"Wen Gong" <quic_wgong@quicinc.com>,
"Muna Sinada" <quic_msinada@quicinc.com>,
"Aditya Kumar Singh" <quic_adisi@quicinc.com>,
ath12k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ath12k: sanitize ath12k_mac_allocate() return code
Date: Wed, 14 Feb 2024 12:44:58 +0200 [thread overview]
Message-ID: <87plwze34l.fsf@kernel.org> (raw)
In-Reply-To: <08ac32ef-610d-479d-a3fd-a3c3b8c4c697@app.fastmail.com> (Arnd Bergmann's message of "Wed, 14 Feb 2024 11:37:52 +0100")
"Arnd Bergmann" <arnd@arndb.de> writes:
> On Wed, Feb 14, 2024, at 09:44, Kalle Valo wrote:
>> Arnd Bergmann <arnd@kernel.org> wrote:
>>
>>> The return code has no initializer:
>>>
>>> drivers/net/wireless/ath/ath12k/mac.c:8006:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>>>
>>> Make it return -ENOMEM for allocation failures and remove the unused
>>> variable instead.
>>>
>>> Fixes: 6db6e70a17f6 ("wifi: ath12k: Introduce the container for mac80211 hw")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> Nathan already fixed this:
>>
>> https://git.kernel.org/kvalo/ath/c/04edb5dc68f4
>>
>> Patch set to Rejected.
>
> Ok, sounds good. Nathan's patch looks fine to me
Great, thanks for checking.
> but I see it's not in linux-next yet as of today.
Yeah, it's a problem that ath.git is not included linux-next builds. The
commits will be in linux-next only after ath-next is pulled to
wireless-next :/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-02-14 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 10:09 [PATCH] wifi: ath12k: sanitize ath12k_mac_allocate() return code Arnd Bergmann
2024-02-14 8:44 ` Kalle Valo
2024-02-14 10:37 ` Arnd Bergmann
2024-02-14 10:44 ` Kalle Valo [this message]
2024-02-14 10:51 ` Arnd Bergmann
2024-02-14 12:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plwze34l.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
--cc=quic_alokad@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_msinada@quicinc.com \
--cc=quic_periyasa@quicinc.com \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).