From: Kalle Valo <kvalo@kernel.org>
To: Pkshih <pkshih@realtek.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"colin.i.king\@gmail.com" <colin.i.king@gmail.com>,
"davem\@davemloft.net" <davem@davemloft.net>,
"kuba\@kernel.org" <kuba@kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel-janitors\@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove redundant initialization of variable ul_encalgo
Date: Tue, 01 Feb 2022 14:22:57 +0200 [thread overview]
Message-ID: <87pmo6dbdq.fsf@kernel.org> (raw)
In-Reply-To: <55f8c7f2c75b18cd628d02a25ed96fae676eace2.camel@realtek.com> (Pkshih's message of "Mon, 31 Jan 2022 02:53:40 +0000")
Pkshih <pkshih@realtek.com> writes:
> On Sun, 2022-01-30 at 22:37 +0000, Colin Ian King wrote:
>> Variable ul_encalgo is initialized with a value that is never read,
>> it is being re-assigned a new value in every case in the following
>> switch statement. The initialization is redundant and can be removed.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
>> ---
>> drivers/net/wireless/realtek/rtlwifi/cam.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/cam.c
>> b/drivers/net/wireless/realtek/rtlwifi/cam.c
>> index 7a0355dc6bab..32970ea4b4e7 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/cam.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/cam.c
>> @@ -208,7 +208,7 @@ void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index)
>>
>> u32 ul_command;
>> u32 ul_content;
>> - u32 ul_encalgo = rtlpriv->cfg->maps[SEC_CAM_AES];
>> + u32 ul_encalgo;
>> u8 entry_i;
>>
>> switch (rtlpriv->sec.pairwise_enc_algorithm) {
>> --
>
> When I check this patch, I find there is no 'break' for default case.
> Do we need one? like
>
> @@ -226,6 +226,7 @@ void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index)
> break;
> default:
> ul_encalgo = rtlpriv->cfg->maps[SEC_CAM_AES];
> + break;
> }
>
> for (entry_i = 0; entry_i < CAM_CONTENT_COUNT; entry_i++) {
Yeah, it would be good to have break for consistency. Can someone send a
separate patch for that?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-02-01 12:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 22:37 [PATCH] rtlwifi: remove redundant initialization of variable ul_encalgo Colin Ian King
2022-01-31 2:53 ` Pkshih
2022-02-01 12:22 ` Kalle Valo [this message]
2022-02-02 5:02 ` Dan Carpenter
2022-02-02 10:10 ` Joe Perches
2022-02-02 11:05 ` Dan Carpenter
2022-02-02 11:21 ` Joe Perches
2022-02-02 11:44 ` Dan Carpenter
2022-02-01 12:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmo6dbdq.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).