* Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' [not found] <202007251817.x5EF2Aoc%lkp@intel.com> @ 2020-08-27 10:46 ` Kalle Valo 2020-08-28 2:25 ` Tony Chuang 0 siblings, 1 reply; 4+ messages in thread From: Kalle Valo @ 2020-08-27 10:46 UTC (permalink / raw) To: kernel test robot Cc: Zong-Zhe Yang, kbuild-all, linux-kernel, Yan-Hsuan Chuang, linux-wireless + linux-wireless kernel test robot <lkp@intel.com> writes: > Hi Zong-Zhe, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract: > export symbols about pci interface > date: 10 weeks ago > config: arc-randconfig-r026-20200725 (attached as .config) > compiler: arc-elf-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes] > 1477 | int rtw_pci_probe(struct pci_dev *pdev, > | ^~~~~~~~~~~~~ >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes] > 1557 | void rtw_pci_remove(struct pci_dev *pdev) > | ^~~~~~~~~~~~~~ >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes] > 1579 | void rtw_pci_shutdown(struct pci_dev *pdev) > | ^~~~~~~~~~~~~~~~ Tony, these are older warnings but please also check these. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' 2020-08-27 10:46 ` drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' Kalle Valo @ 2020-08-28 2:25 ` Tony Chuang 2020-08-28 6:01 ` Kalle Valo 0 siblings, 1 reply; 4+ messages in thread From: Tony Chuang @ 2020-08-28 2:25 UTC (permalink / raw) To: Kalle Valo, kernel test robot Cc: Kevin Yang, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org > + linux-wireless > > kernel test robot <lkp@intel.com> writes: > > > Hi Zong-Zhe, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 > > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract: > > export symbols about pci interface > > date: 10 weeks ago > > config: arc-randconfig-r026-20200725 (attached as .config) > > compiler: arc-elf-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > > -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 > make.cross ARCH=arc > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@intel.com> > > > > All warnings (new ones prefixed by >>): > > > >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no > >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes] > > 1477 | int rtw_pci_probe(struct pci_dev *pdev, > > | ^~~~~~~~~~~~~ > >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no > >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes] > > 1557 | void rtw_pci_remove(struct pci_dev *pdev) > > | ^~~~~~~~~~~~~~ > >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no > >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes] > > 1579 | void rtw_pci_shutdown(struct pci_dev *pdev) > > | ^~~~~~~~~~~~~~~~ > > Tony, these are older warnings but please also check these. > I think this warning can be ignored, as the commit was going to export pci symbols for the follow-up patches to use, such as: f56f08636dda rtw88: extract: make 8723d an individual kernel module 416e87fcc780 rtw88: extract: make 8822b an individual kernel module ba0fbe236fb8 rtw88: extract: make 8822c an individual kernel module And these patches were submitted and applied together. Thanks, Yen-Hsuan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' 2020-08-28 2:25 ` Tony Chuang @ 2020-08-28 6:01 ` Kalle Valo 0 siblings, 0 replies; 4+ messages in thread From: Kalle Valo @ 2020-08-28 6:01 UTC (permalink / raw) To: Tony Chuang Cc: kernel test robot, Kevin Yang, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Tony Chuang <yhchuang@realtek.com> writes: >> + linux-wireless >> >> kernel test robot <lkp@intel.com> writes: >> >> > Hi Zong-Zhe, >> > >> > FYI, the error/warning still remains. >> > >> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 >> > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract: >> > export symbols about pci interface >> > date: 10 weeks ago >> > config: arc-randconfig-r026-20200725 (attached as .config) >> > compiler: arc-elf-gcc (GCC) 9.3.0 >> > reproduce (this is a W=1 build): >> > wget >> > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> > -O ~/bin/make.cross >> > chmod +x ~/bin/make.cross >> > git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36 >> > # save the attached .config to linux build tree >> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 >> make.cross ARCH=arc >> > >> > If you fix the issue, kindly add following tag as appropriate >> > Reported-by: kernel test robot <lkp@intel.com> >> > >> > All warnings (new ones prefixed by >>): >> > >> >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no >> >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes] >> > 1477 | int rtw_pci_probe(struct pci_dev *pdev, >> > | ^~~~~~~~~~~~~ >> >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no >> >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes] >> > 1557 | void rtw_pci_remove(struct pci_dev *pdev) >> > | ^~~~~~~~~~~~~~ >> >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no >> >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes] >> > 1579 | void rtw_pci_shutdown(struct pci_dev *pdev) >> > | ^~~~~~~~~~~~~~~~ >> >> Tony, these are older warnings but please also check these. >> > > I think this warning can be ignored, as the commit was going to export > pci symbols for the follow-up patches to use, such as: > > f56f08636dda rtw88: extract: make 8723d an individual kernel module > 416e87fcc780 rtw88: extract: make 8822b an individual kernel module > ba0fbe236fb8 rtw88: extract: make 8822c an individual kernel module > > And these patches were submitted and applied together. Good, thanks for checking. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <202009132352.cN4c9rTC%lkp@intel.com>]
[parent not found: <6463246c14a24bc989ea56d9c4443784@realtek.com>]
* Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' [not found] ` <6463246c14a24bc989ea56d9c4443784@realtek.com> @ 2020-09-14 7:17 ` Kalle Valo 0 siblings, 0 replies; 4+ messages in thread From: Kalle Valo @ 2020-09-14 7:17 UTC (permalink / raw) To: Tony Chuang Cc: kernel test robot, Kevin Yang, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-wireless Tony Chuang <yhchuang@realtek.com> writes: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: ef2e9a563b0cd7965e2a1263125dcbb1c86aa6cc >> commit: ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 rtw88: extract: make >> 8822c an individual kernel module >> date: 4 months ago >> config: i386-randconfig-r034-20200913 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 >> reproduce (this is a W=1 build): >> git checkout ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 >> # save the attached .config to linux build tree >> make W=1 ARCH=i386 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@intel.com> >> >> All warnings (new ones prefixed by >>): >> >> >> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous >> >> prototype for 'rtw_pci_probe' [-Wmissing-prototypes] >> 1477 | int rtw_pci_probe(struct pci_dev *pdev, >> | ^~~~~~~~~~~~~ >> >> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no previous >> >> prototype for 'rtw_pci_remove' [-Wmissing-prototypes] >> 1557 | void rtw_pci_remove(struct pci_dev *pdev) >> | ^~~~~~~~~~~~~~ >> >> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous >> >> prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes] >> 1579 | void rtw_pci_shutdown(struct pci_dev *pdev) >> | ^~~~~~~~~~~~~~~~ >> [...] > Hi Kalle, > > The exported function is used by the following patchset. > So this is a false alarm. Good, thanks for checking. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-14 7:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202007251817.x5EF2Aoc%lkp@intel.com>
2020-08-27 10:46 ` drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' Kalle Valo
2020-08-28 2:25 ` Tony Chuang
2020-08-28 6:01 ` Kalle Valo
[not found] <202009132352.cN4c9rTC%lkp@intel.com>
[not found] ` <6463246c14a24bc989ea56d9c4443784@realtek.com>
2020-09-14 7:17 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).