From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDC3C0650E for ; Mon, 1 Jul 2019 10:50:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD747208E4 for ; Mon, 1 Jul 2019 10:50:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="itaQMXmp"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dWhrbNuF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727885AbfGAKuB (ORCPT ); Mon, 1 Jul 2019 06:50:01 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39988 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbfGAKuB (ORCPT ); Mon, 1 Jul 2019 06:50:01 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0C75161634; Mon, 1 Jul 2019 10:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561978201; bh=aQJl/9MUObNguNsjIkQXsv9cLEnSfYWzIb12gAP3T5M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=itaQMXmpHsScL3e981PUj6zNlLr/rVMCL10zIRLDz1S2aqLptIvPpK65RyYdDyFan HLEdr/+xOGzo3cT+UhdjBQFViJ6hz4yiF7eKg0r0ZR/piAt4zdcX6/PecC8gw+ginp Fw1OROvLvHylWfvVDfIVJ2YS5VMOC2482OAH0u7U= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7EB7F615E8; Mon, 1 Jul 2019 10:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561978197; bh=aQJl/9MUObNguNsjIkQXsv9cLEnSfYWzIb12gAP3T5M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dWhrbNuFqZ+SwoFXL/jDlLXtEGYvtICwZ62254IsuMpbgvlkHpEimyCJffE4QQFGP UvEPgp1Vfn3qVajcSo6UvaBPPiq1t7VeJtuN+csvmacPAXJsbyKZjY2Lzn/k7AklIY K470syMV5Uo8zNWx4UpmeuEWolNdT2fso0nQHp6k= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7EB7F615E8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Ryder Lee Cc: Lorenzo Bianconi , Lorenzo Bianconi , Felix Fietkau , linux-wireless , Roy Luo , YF Luo , Subject: Re: [PATCH 4/6] mt76: mt7615: unlock dfs bands References: <33184e0b78983fe7c79fa70c5fbb21042aafa4f5.1561804422.git.lorenzo@kernel.org> <87muhzs9qv.fsf@purkki.adurom.net> <87tvc69odh.fsf@kamboji.qca.qualcomm.com> <1561975021.3950.9.camel@mtkswgap22> Date: Mon, 01 Jul 2019 13:49:52 +0300 In-Reply-To: <1561975021.3950.9.camel@mtkswgap22> (Ryder Lee's message of "Mon, 1 Jul 2019 17:57:01 +0800") Message-ID: <87pnmu9ghb.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ryder Lee writes: > On Mon, 2019-07-01 at 10:59 +0300, Kalle Valo wrote: >> Lorenzo Bianconi writes: >> >> >> >> >> Lorenzo Bianconi writes: >> >> >> >> > Unlock dfs channels since now mt7615 driver supports radar detection >> >> > >> >> > Signed-off-by: Lorenzo Bianconi >> >> > --- >> >> > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 6 ++++++ >> >> > 1 file changed, 6 insertions(+) >> >> > >> >> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c >> >> > index 5dc4cced5789..6d336d82cafe 100644 >> >> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c >> >> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c >> >> > @@ -152,6 +152,12 @@ static const struct ieee80211_iface_combination if_comb[] = { >> >> > .max_interfaces = 4, >> >> > .num_different_channels = 1, >> >> > .beacon_int_infra_match = true, >> >> > + .radar_detect_widths = BIT(NL80211_CHAN_WIDTH_20_NOHT) | >> >> > + BIT(NL80211_CHAN_WIDTH_20) | >> >> > + BIT(NL80211_CHAN_WIDTH_40) | >> >> > + BIT(NL80211_CHAN_WIDTH_80) | >> >> > + BIT(NL80211_CHAN_WIDTH_160) | >> >> > + BIT(NL80211_CHAN_WIDTH_80P80), >> >> >> >> Isn't it questionable to enable these without any testing on real >> >> hardware? Getting DFS to work correctly is hard so I'm very suspicious >> >> about this. >> >> >> >> -- >> >> Kalle Valo >> > >> > Hi Kalle, >> > >> > unfortunately at the moment I am not able to run any tests with a real >> > signal generator so I just ported the code from vendor sdk. >> > I am pretty confident it works since the radar pattern detection is >> > done in fw/hw so I guess it has been already tested in the vendor sdk >> >> DFS is really tricky to get it working right, so I'm not easily >> convinced :) >> >> > but we can postpone this patch and apply just the rest of the series >> > until we have some test results. >> >> Yeah, I think it would be best to drop this patch so that DFS is not >> enabled by default and apply this patch only after positive test >> results. >> > > That's why I suggested Lorenzo to add this one - "[6/6] mt76: mt7615: > add radar pattern test knob to debugfs" > > We can feed radar pattern through debugfs to test if a pattern is > detected as radar pattern or not and verify the fw radar detection > algorithm. Sure, that's nice for testing but does not guarantee that it works with real hardware as well. I take regulatory rules very seriously and that's why I'm extra careful here. -- Kalle Valo