From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Tony Chuang <yhchuang@realtek.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
"sgruszka\@redhat.com" <sgruszka@redhat.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips
Date: Tue, 29 Jan 2019 09:53:58 +0200 [thread overview]
Message-ID: <87pnsfucfd.fsf@purkki.adurom.net> (raw)
In-Reply-To: <CA+ASDXM=+_U+SrXhm3pq4Zd7gkvHwkRAZw+OGmzg=6+0+=iZGg@mail.gmail.com> (Brian Norris's message of "Mon, 28 Jan 2019 18:41:06 -0800")
Brian Norris <briannorris@chromium.org> writes:
> On Mon, Jan 28, 2019 at 6:15 PM Tony Chuang <yhchuang@realtek.com> wrote:
>> This NULL pointer was found months ago and has been fixed already.
>> Thanks for your test :).
>> I am holding the patch to fix it for the next patchsets.
>>
>> BTW, since rtw88 has not been accepted, could I send next patch set based on
>> this patch set as long as I explicitly mark that the next patch is based on the previous one?
>
> I'd normally expect that if you find major bugs in your initial driver
> submission that still isn't reviewed/merged, you might as well just
> roll the fix into latest version and describe it in the
> cover-letter/changelog. This particular change is so trivial it
> doesn't really seem to deserve a separate patch.
>
> (It would also help people like me, who may very well run into the
> same bug when they get around to testing/reviewing the driver.)
>
> I also don't know what the contents of the "next patch set" is -- if
> it's a lot of new features, maybe they don't deserve to clutter the
> initial submission, but if they're bugfixes like this, it seems like
> you could just fix the original patch set.
This is what I suggest as well. Don't add new features or any other
large changes while the driver is under review, instead keep them in a
separate branch etc. But bugfixes are ok.
--
Kalle Valo
next prev parent reply other threads:[~2019-01-29 7:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 5:46 [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2019-01-28 5:46 ` [PATCH v3 01/13] rtw88: main files yhchuang
2019-01-28 5:46 ` [PATCH v3 02/13] rtw88: core files yhchuang
2019-01-28 5:46 ` [PATCH v3 03/13] rtw88: hci files yhchuang
2019-01-28 5:46 ` [PATCH v3 04/13] rtw88: trx files yhchuang
2019-01-28 5:46 ` [PATCH v3 05/13] rtw88: mac files yhchuang
2019-01-28 5:46 ` [PATCH v3 06/13] rtw88: fw and efuse files yhchuang
2019-01-28 5:46 ` [PATCH v3 07/13] rtw88: phy files yhchuang
2019-01-28 5:46 ` [PATCH v3 08/13] rtw88: debug files yhchuang
2019-01-28 5:46 ` [PATCH v3 09/13] rtw88: chip files yhchuang
2019-01-28 5:46 ` [PATCH v3 10/13] rtw88: 8822B init table yhchuang
2019-01-28 5:46 ` [PATCH v3 11/13] rtw88: 8822C " yhchuang
2019-01-28 5:46 ` [PATCH v3 12/13] rtw88: Kconfig & Makefile yhchuang
2019-01-28 5:46 ` [PATCH v3 13/13] rtw88: add support for Realtek 802.11ac wireless chips yhchuang
2019-01-28 8:36 ` [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Kalle Valo
2019-01-28 9:25 ` Tony Chuang
2019-01-28 10:12 ` Stanislaw Gruszka
2019-01-28 22:38 ` Brian Norris
2019-01-29 2:27 ` Tony Chuang
2019-01-28 20:56 ` Larry Finger
2019-01-29 2:15 ` Tony Chuang
2019-01-29 2:41 ` Brian Norris
2019-01-29 2:53 ` Tony Chuang
2019-01-29 7:53 ` Kalle Valo [this message]
2019-01-29 3:23 ` Larry Finger
2019-01-29 4:03 ` Tony Chuang
2019-01-29 7:59 ` Kalle Valo
2019-01-29 13:01 ` Tony Chuang
2019-01-29 17:23 ` Kalle Valo
2019-01-29 14:54 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnsfucfd.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=sgruszka@redhat.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).