From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:44732 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934106AbeEIJsZ (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Wed, 9 May 2018 05:48:25 -0400
From: Kalle Valo <kvalo@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        kbuild test robot <lkp@intel.com>, kbuild-all@01.org,
        linux-wireless@vger.kernel.org, Maya Erez <merez@codeaurora.org>
Subject: Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes
References: <201805090154.h4Cokbx2%fengguang.wu@intel.com>
        <87efil2p2o.fsf@purkki.adurom.net>
        <1525855900.6910.5.camel@sipsolutions.net>
        <87tvrhw6kj.fsf@kamboji.qca.qualcomm.com>
        <1525856418.6910.6.camel@sipsolutions.net> <87efil41d4.fsf@toke.dk>
        <1525858618.6910.9.camel@sipsolutions.net>
Date: Wed, 09 May 2018 12:48:20 +0300
In-Reply-To: <1525858618.6910.9.camel@sipsolutions.net> (Johannes Berg's
        message of "Wed, 09 May 2018 11:36:58 +0200")
Message-ID: <87po25w463.fsf@kamboji.qca.qualcomm.com> (sfid-20180509_114954_416319_1A82EE76)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

Johannes Berg <johannes@sipsolutions.net> writes:

> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>=20
>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>> > >=20
>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>> > > > >=20
>> > > > > I guess these warnings come because Toke's patch increased size =
of
>> > > > > struct cfg80211_tid_stats (which is included in struct station_i=
nfo) and
>> > > > > both wil6210 and qtnfmac allocate a struct station_info from sta=
ck?=20
>> > > >=20
>> > > > Yes.
>> > > >=20
>> > > > > Can
>> > > > > someone send a fix for the drivers?
>> > > >=20
>> > > > I guess Toke/I should do that through my tree.
>> > >=20
>> > > IMHO the fix could go through my tree as well, less risk of conflict=
s in
>> > > drivers. AFAICS the fix (allocating station_info dynamically?) would=
 not
>> > > depend on Toke's patch and could be applied separately.
>> >=20
>> > That's true, if you prefer that it's fine with me.
>>=20
>> I'll send a patch.
>>=20
>> What's the right tag to put in the commit for this?
>> Fixes-but-is-independent-from: ? ;)
>
> Heh. You can still put Fixes: I think.

Yeah, I think so too.

--=20
Kalle Valo