Re: [PATCHv3 1/3] ath10k: move firmware_swap_code_seg_info to ath10k_fw_file

["Valo, Kalle" <kvalo@qca.qualcomm.com>]

Julian Calaby <julian.calaby@gmail.com> writes:

> Hi Tamizh,
>
> On Fri, Jul 1, 2016 at 5:06 PM,  <c_traja@qti.qualcomm.com> wrote:
>> From: Tamizh chelvam <c_traja@qti.qualcomm.com>
>>
>> Preparation to make use of firmware_swap_code_seg_info for UTF binary.
>>
>> Signed-off-by: Tamizh chelvam <c_traja@qti.qualcomm.com>
>> ---
>>  drivers/net/wireless/ath/ath10k/core.c |    6 +++---
>>  drivers/net/wireless/ath/ath10k/core.h |    6 ++----
>>  drivers/net/wireless/ath/ath10k/swap.c |   26 ++++++++++++++-----------=
-
>>  drivers/net/wireless/ath/ath10k/swap.h |   11 ++++++++---
>>  4 files changed, 27 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wirele=
ss/ath/ath10k/core.h
>> index 3da18c9..e69e7e7 100644
>> --- a/drivers/net/wireless/ath/ath10k/core.h
>> +++ b/drivers/net/wireless/ath/ath10k/core.h
>> @@ -654,6 +654,8 @@ struct ath10k_fw_file {
>>
>>         const void *codeswap_data;
>>         size_t codeswap_len;
>> +       /* FIXME: add a comment */
>> +       struct ath10k_swap_code_seg_info *firmware_swap_code_seg_info;
>
> Why not just add a comment? Adding FIXMEs makes the patch look incomplete=
 to me.

Actually I'm here to blame, I asked Tamizh to add the fixme so I can add
a proper comment. I did it now:

--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -663,7 +663,14 @@ struct ath10k_fw_file {
=20
        const void *codeswap_data;
        size_t codeswap_len;
-       /* FIXME: add a comment */
+
+       /* The original idea of struct ath10k_fw_file was that it only
+        * contains struct firmware and pointers to various parts (actual
+        * firmware binary, otp, metadata etc) of the file. This seg_info
+        * is actually created separate but as this is used similarly as
+        * the other firmware components it's more convenient to have it
+        * here.
+        */
        struct ath10k_swap_code_seg_info *firmware_swap_code_seg_info;
 };

--=20
Kalle Valo=