From: Kalle Valo <kvalo@codeaurora.org>
To: meijjaa <jjmeijer88@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Fix regression in Android due to rework .get_station() callback
Date: Fri, 06 May 2016 14:51:59 +0300 [thread overview]
Message-ID: <87poszs8tc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1462280620-13000-1-git-send-email-jjmeijer88@gmail.com> (meijjaa's message of "Tue, 3 May 2016 15:03:40 +0200")
meijjaa <jjmeijer88@gmail.com> writes:
> After f654d13 Android is not able to get station signal strength.
> To much was removed, this patch brings back the needed functionality.
>
> Signed-off-by: meijjaa <jjmeijer88@gmail.com>
This has multiple issues:
o Use your full name.
o Use prefix "brcmfmac: " in the title.
o I can't find commit f654d13, is the commit id really correct?
o Also check from SubmittingPatches how you should reference commit ids.
--
Kalle Valo
next prev parent reply other threads:[~2016-05-06 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 13:03 [PATCH] Fix regression in Android due to rework .get_station() callback meijjaa
2016-05-06 11:51 ` Kalle Valo [this message]
[not found] ` <CAA+NYvTxA_u1kjwmY+VTnhK0G1b5cEcx2QA90fTTEkci4gWvcQ@mail.gmail.com>
[not found] ` <87wpn7p6dv.fsf@kamboji.qca.qualcomm.com>
2016-05-06 15:57 ` Jaap Jan Meijer
2016-05-06 16:02 ` Kalle Valo
2016-05-08 11:20 ` Jaap Jan Meijer
2016-05-09 14:17 ` Kalle Valo
2016-05-09 9:11 ` Arend Van Spriel
2016-05-09 14:21 ` Kalle Valo
2016-05-10 11:34 ` Jaap Jan Meijer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poszs8tc.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=jjmeijer88@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).