linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: Larry.Finger@lwfinger.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code.
Date: Fri, 08 May 2015 16:01:05 +0300	[thread overview]
Message-ID: <87pp6bp6jy.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1430841518-3932-1-git-send-email-ap420073@gmail.com> (Taehee Yoo's message of "Wed, 6 May 2015 00:58:38 +0900")

Taehee Yoo <ap420073@gmail.com> writes:

> 1. Remove setting REG_BCN_MAX_ERR code in _rtl92cu_set_media_status().
> Initialization routine set REG_BCN_MAX_ERR to 0xFF.
> also _rtl92cu_set_media_status set REG_BCN_MAX_ERR to same value.
> so i remove this code.
>
> 2. Remove rtl92c_init_beacon_max_error's parameter.
> because parameter "infra_mode" is not used.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>

Please split the patches into two. Having a numbered list of changes in
the commit log is a strong indication that the patch should be split
into smaller patches.

-- 
Kalle Valo

  reply	other threads:[~2015-05-08 13:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 15:58 [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code Taehee Yoo
2015-05-08 13:01 ` Kalle Valo [this message]
2015-05-09  9:11   ` Taehee Yoo
2015-05-09 12:02     ` Kalle Valo
2015-05-09 18:12       ` Taehee Yoo
2015-05-11  6:39         ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pp6bp6jy.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=ap420073@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).