From: Kalle Valo <kvalo@codeaurora.org>
To: "Grumbach\, Emmanuel" <emmanuel.grumbach@intel.com>
Cc: "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: pull request: iwlwifi 2015-01-05
Date: Mon, 05 Jan 2015 12:17:39 +0200 [thread overview]
Message-ID: <87ppat3518.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1420449079.12040.3.camel@egrumbacBox> (Emmanuel Grumbach's message of "Mon, 5 Jan 2015 09:11:18 +0000")
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> writes:
> This is new content for 3.19. Details in the tag. Let me know if you have issues.
> Thanks!
Thanks, pulled.
One comment:
> ----------------------------------------------------------------
> * fix for 7265D NVM check
> * fixes for scan: fix long scanning times and network
> discovery
> * new firmware API for iwlmvm supported devices
> * fixes in rate control
>
> ----------------------------------------------------------------
> Arik Nemtsov (1):
> iwlwifi: pcie: correctly define 7265-D cfg
>
> David Spinadel (2):
> iwlwifi: mvm: add a flag to enable match found notification
> iwlwifi: mvm: scan dwell time corrections
>
> Emmanuel Grumbach (2):
> iwlwifi: 7000: fix reported firmware name for 7265D
> iwlwifi: bump firmware API for mvm devices to 12
To me the firmware API bump is in a gray area, I don't see how it really
fixes anything. I would feel much more comfortable if the patch would
document why the bump is needed in -rc series and why it couldn't wait
for -next. I'm guessing it has somethign to do with the dwell time
corrections, but it's not obvious to me (and others).
--
Kalle Valo
next prev parent reply other threads:[~2015-01-05 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 9:11 pull request: iwlwifi 2015-01-05 Grumbach, Emmanuel
2015-01-05 10:17 ` Kalle Valo [this message]
2015-01-05 10:41 ` Grumbach, Emmanuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppat3518.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).