pull request: iwlwifi 2015-01-05

pull request: iwlwifi 2015-01-05

[Grumbach, Emmanuel]

SGkgS2FsbGUsDQoNClRoaXMgaXMgbmV3IGNvbnRlbnQgZm9yIDMuMTkuIERldGFpbHMgaW4gdGhl
IHRhZy4gTGV0IG1lIGtub3cgaWYgeW91IGhhdmUgaXNzdWVzLg0KVGhhbmtzIQ0KDQoNClRoZSBm
b2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgYmFhMjFlODM0OTQxZWU1ZmJlNGJkNDIxYzg3
MWY3YzBjNWY5YTA4NjoNCg0KICBpd2x3aWZpOiBwY2llOiBsaW1pdCBmdyBjaHVuayBzaXplcyBn
aXZlbiB0byBmaCAoMjAxNC0xMi0xNCAxMDoyMDozMCArMDIwMCkNCg0KYXJlIGF2YWlsYWJsZSBp
biB0aGUgZ2l0IHJlcG9zaXRvcnkgYXQ6DQoNCiAgaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIv
c2NtL2xpbnV4L2tlcm5lbC9naXQvaXdsd2lmaS9pd2x3aWZpLWZpeGVzLmdpdCB0YWdzL2l3bHdp
ZmktZm9yLWthbGxlLTIwMTUtMDEtMDUNCg0KZm9yIHlvdSB0byBmZXRjaCBjaGFuZ2VzIHVwIHRv
IDkxZjQ5MWZkN2RmYmFlNmU1Y2U1ODg3MjkzNzIzZDgxOGFkZjdkNWQ6DQoNCiAgaXdsd2lmaTog
YnVtcCBmaXJtd2FyZSBBUEkgZm9yIG12bSBkZXZpY2VzIHRvIDEyICgyMDE1LTAxLTA1IDExOjAy
OjM3ICswMjAwKQ0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tDQoqIGZpeCBmb3IgNzI2NUQgTlZNIGNoZWNrDQoqIGZpeGVz
IGZvciBzY2FuOiBmaXggbG9uZyBzY2FubmluZyB0aW1lcyBhbmQgbmV0d29yaw0KCWRpc2NvdmVy
eQ0KKiBuZXcgZmlybXdhcmUgQVBJIGZvciBpd2xtdm0gc3VwcG9ydGVkIGRldmljZXMNCiogZml4
ZXMgaW4gcmF0ZSBjb250cm9sDQoNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCkFyaWsgTmVtdHNvdiAoMSk6DQogICAgICBp
d2x3aWZpOiBwY2llOiBjb3JyZWN0bHkgZGVmaW5lIDcyNjUtRCBjZmcNCg0KRGF2aWQgU3BpbmFk
ZWwgKDIpOg0KICAgICAgaXdsd2lmaTogbXZtOiBhZGQgYSBmbGFnIHRvIGVuYWJsZSBtYXRjaCBm
b3VuZCBub3RpZmljYXRpb24NCiAgICAgIGl3bHdpZmk6IG12bTogc2NhbiBkd2VsbCB0aW1lIGNv
cnJlY3Rpb25zDQoNCkVtbWFudWVsIEdydW1iYWNoICgyKToNCiAgICAgIGl3bHdpZmk6IDcwMDA6
IGZpeCByZXBvcnRlZCBmaXJtd2FyZSBuYW1lIGZvciA3MjY1RA0KICAgICAgaXdsd2lmaTogYnVt
cCBmaXJtd2FyZSBBUEkgZm9yIG12bSBkZXZpY2VzIHRvIDEyDQoNCkV5YWwgU2hhcGlyYSAoMik6
DQogICAgICBpd2x3aWZpOiBtdm06IGZpeCBSeCB3aXRoIGJvdGggY2hhaW5zDQogICAgICBpd2x3
aWZpOiBtdm06IGZpeCBvdXQgb2YgYm91bmRzIGFjY2VzcyB0byB0aWRfdG9fbWFjODAyMTFfYWMN
Cg0KIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvaXdsLTcwMDAuYyAgICAgICAgfCAgNiAr
KystLS0NCiBkcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2l3bC04MDAwLmMgICAgICAgIHwg
IDIgKy0NCiBkcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2l3bC1mdy1maWxlLmggICAgIHwg
IDQgKysrKw0KIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvbXZtL2Z3LWFwaS1zY2FuLmgg
fCAgMiArKw0KIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvbXZtL3NjYW4uYyAgICAgICAg
fCAxOSArKysrKysrKysrKysrKy0tLS0tDQogZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9t
dm0vdHguYyAgICAgICAgICB8ICA4ICsrKysrKy0tDQogZHJpdmVycy9uZXQvd2lyZWxlc3MvaXds
d2lmaS9tdm0vdXRpbHMuYyAgICAgICB8ICAyICstDQogZHJpdmVycy9uZXQvd2lyZWxlc3MvaXds
d2lmaS9wY2llL2Rydi5jICAgICAgICB8ICA0ICsrKy0NCiA4IGZpbGVzIGNoYW5nZWQsIDM0IGlu
c2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQ0KDQo=

Re: pull request: iwlwifi 2015-01-05

[Kalle Valo]

"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> writes:

> This is new content for 3.19. Details in the tag. Let me know if you have issues.
> Thanks!

Thanks, pulled.

One comment:

> ----------------------------------------------------------------
> * fix for 7265D NVM check
> * fixes for scan: fix long scanning times and network
> 	discovery
> * new firmware API for iwlmvm supported devices
> * fixes in rate control
>
> ----------------------------------------------------------------
> Arik Nemtsov (1):
>       iwlwifi: pcie: correctly define 7265-D cfg
>
> David Spinadel (2):
>       iwlwifi: mvm: add a flag to enable match found notification
>       iwlwifi: mvm: scan dwell time corrections
>
> Emmanuel Grumbach (2):
>       iwlwifi: 7000: fix reported firmware name for 7265D
>       iwlwifi: bump firmware API for mvm devices to 12

To me the firmware API bump is in a gray area, I don't see how it really
fixes anything. I would feel much more comfortable if the patch would
document why the bump is needed in -rc series and why it couldn't wait
for -next. I'm guessing it has somethign to do with the dwell time
corrections, but it's not obvious to me (and others).

-- 
Kalle Valo

RE: pull request: iwlwifi 2015-01-05

[Grumbach, Emmanuel]

> 
> "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> writes:
> 
> > This is new content for 3.19. Details in the tag. Let me know if you have
> issues.
> > Thanks!
> 
> Thanks, pulled.
> 
> One comment:
> 
> > ----------------------------------------------------------------
> > * fix for 7265D NVM check
> > * fixes for scan: fix long scanning times and network
> > 	discovery
> > * new firmware API for iwlmvm supported devices
> > * fixes in rate control
> >
> > ----------------------------------------------------------------
> > Arik Nemtsov (1):
> >       iwlwifi: pcie: correctly define 7265-D cfg
> >
> > David Spinadel (2):
> >       iwlwifi: mvm: add a flag to enable match found notification
> >       iwlwifi: mvm: scan dwell time corrections
> >
> > Emmanuel Grumbach (2):
> >       iwlwifi: 7000: fix reported firmware name for 7265D
> >       iwlwifi: bump firmware API for mvm devices to 12
> 
> To me the firmware API bump is in a gray area, I don't see how it really fixes
> anything. I would feel much more comfortable if the patch would document
> why the bump is needed in -rc series and why it couldn't wait for -next. I'm
> guessing it has somethign to do with the dwell time corrections, but it's not
> obvious to me (and others).
> 

The bum firmware API is gray area - but it allows to load new firmware that typically
have lots of bug fixes. Especially since 3.19 will probably be used by major distributions
and I want to be able to load the new firmware there.
The driver code in 3.19 is ready to load the 12 firmware, hence the change.