From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: avoid possible deadlock with scan timeout
Date: Fri, 31 Oct 2014 02:17:33 +0200 [thread overview]
Message-ID: <87ppd9drdu.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1414488189-28625-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 28 Oct 2014 10:23:09 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
> This should prevent deadlock predicted by the
> following splat:
>
> ======================================================
> [ INFO: possible circular locking dependency detected ]
> 3.17.0-wl-ath+ #67 Not tainted
> -------------------------------------------------------
> kworker/u32:1/7230 is trying to acquire lock:
> (&ar->conf_mutex){+.+.+.}, at: [<ffffffffa040a57d>] ath10k_scan_timeout_work+0x2d/0x50 [ath10k_core]
>
> but task is already holding lock:
> ((&(&ar->scan.timeout)->work)){+.+...}, at: [<ffffffff8106dae1>] process_one_work+0x151/0x470
>
> which lock already depends on the new lock.
>
[...]
> *** DEADLOCK ***
>
> Reported-by: Marek Puzyniak <marek.puzyniak@tieto.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Thanks, applied.
--
Kalle Valo
prev parent reply other threads:[~2014-10-31 0:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 9:23 [PATCH] ath10k: avoid possible deadlock with scan timeout Michal Kazior
2014-10-31 0:17 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppd9drdu.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).