From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:1502 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbaHSML3 (ORCPT ); Tue, 19 Aug 2014 08:11:29 -0400 From: Kalle Valo To: CC: , Subject: Re: [PATCH] ath10k: improve logging in firmware crash routine. References: <1407271772-14874-1-git-send-email-greearb@candelatech.com> Date: Tue, 19 Aug 2014 15:11:21 +0300 In-Reply-To: <1407271772-14874-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Tue, 5 Aug 2014 13:49:32 -0700") Message-ID: <87ppfwadcm.fsf@kamboji.qca.qualcomm.com> (sfid-20140819_141132_947547_FEEB6BEF) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: greearb@candelatech.com writes: > From: Ben Greear > > Only print error message upon failure, and print more > details in case it does find an error. > > Signed-off-by: Ben Greear > --- > > This is on top of the firmware crash reporting patches, > not sure it would apply clean until those get in. Yeah, this does conflict with the firmware crash dump patches. > drivers/net/wireless/ath/ath10k/pci.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c > index 24688b7..085c0c8 100644 > --- a/drivers/net/wireless/ath/ath10k/pci.c > +++ b/drivers/net/wireless/ath/ath10k/pci.c > @@ -929,12 +929,11 @@ static void ath10k_pci_hif_dump_area(struct ath10k *ar) > ret = ath10k_pci_diag_read_mem(ar, host_addr, > ®_dump_area, sizeof(u32)); > if (ret) { > - ath10k_err("failed to read FW dump area address: %d\n", ret); > + ath10k_err("failed to read FW dump area address: %d (hostaddr 0x%08X hi-failure-state 0x%08lX)\n", > + ret, host_addr, HI_ITEM(hi_failure_state)); > goto exit; > } As I reworked how the diag interface is used, this doesn't directly apply anymore. And are these values really that important? > - ath10k_err("target register Dump Location: 0x%08X\n", reg_dump_area); I actually removed this line in the firmware crash dump patchset. -- Kalle Valo